Skip to content

KAFKA-14577: Move ConsoleProducer to tools module#17157

Merged
mimaison merged 7 commits intoapache:trunkfrom
wernerdv:KAFKA-14577
Oct 7, 2024
Merged

KAFKA-14577: Move ConsoleProducer to tools module#17157
mimaison merged 7 commits intoapache:trunkfrom
wernerdv:KAFKA-14577

Conversation

@wernerdv
Copy link
Copy Markdown
Contributor

@wernerdv wernerdv commented Sep 10, 2024

Based on #13214

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@wernerdv
Copy link
Copy Markdown
Contributor Author

wernerdv commented Sep 15, 2024

@mimaison @chia7712 May I ask you to take a look at this?

@wernerdv
Copy link
Copy Markdown
Contributor Author

wernerdv commented Sep 24, 2024

@mimaison @chia7712 PTAL.

@github-actions github-actions Bot added core Kafka Broker tools labels Sep 26, 2024
@wernerdv
Copy link
Copy Markdown
Contributor Author

wernerdv commented Sep 28, 2024

@dajac @fvaleri @clolov Can I ask you to take a look at this PR, based on #13214?

mimaison
mimaison reviewed Oct 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I left a few comments.

Comment thread checkstyle/import-control.xml
Comment thread tools/src/main/java/org/apache/kafka/tools/ConsoleProducer.java
Comment thread core/src/main/scala/kafka/utils/ToolsUtils.scala
Comment thread tools/src/main/java/org/apache/kafka/tools/ConsoleProducer.java Outdated
Comment thread tools/src/test/java/org/apache/kafka/tools/ConsoleProducerTest.java Outdated
fvaleri
fvaleri reviewed Oct 1, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@fvaleri fvaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wernerdv, I left few comments, but it looks mostly good.

Comment thread tools/src/main/java/org/apache/kafka/tools/LineMessageReader.java
Comment thread tools/src/main/java/org/apache/kafka/tools/ConsoleProducer.java Outdated
@github-actions github-actions Bot added the docker Official Docker image label Oct 1, 2024
@wernerdv wernerdv requested review from fvaleri and mimaison October 1, 2024 20:10
fvaleri
fvaleri approved these changes Oct 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@fvaleri fvaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

mimaison
mimaison approved these changes Oct 7, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR

@mimaison mimaison merged commit 672c617 into apache:trunk Oct 7, 2024
@mimaison mimaison mentioned this pull request Oct 7, 2024
Closed
3 tasks
@wernerdv wernerdv deleted the KAFKA-14577 branch October 7, 2024 09:26
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
@wernerdv @tedyu
KAFKA-14577: Move ConsoleProducer to tools module (apache#17157)
db45229 
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Federico Valeri <fedevaleri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mimaison mimaison mimaison approved these changes

+1 more reviewer

@fvaleri fvaleri fvaleri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-approved core Kafka Broker docker Official Docker image tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wernerdv @mimaison @fvaleri @mumrah