Skip to content

KAFKA-17559: Fix the flaky RemoteLogOffsetReader#testTaskQueueFullAndCancelTask#17214

Merged
satishd merged 3 commits intoapache:trunkfrom
kamalcph:KAFKA-17559
Sep 18, 2024
Merged

KAFKA-17559: Fix the flaky RemoteLogOffsetReader#testTaskQueueFullAndCancelTask#17214
satishd merged 3 commits intoapache:trunkfrom
kamalcph:KAFKA-17559

Conversation

@kamalcph
Copy link
Copy Markdown
Contributor

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Comment thread core/src/test/java/kafka/log/remote/RemoteLogOffsetReaderTest.java
Copy link
Copy Markdown
Member

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a build perspective. I'll let others comment on the nature of the fix.

I just re-ran the tests for a third time. If this run passes, let's merge it and monitor this test on trunk (assuming another LGTM)

Copy link
Copy Markdown
Member

@satishd satishd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kamalcph for the PR, left a minor comment.

Comment thread core/src/test/java/kafka/log/remote/RemoteLogOffsetReaderTest.java Outdated
@satishd satishd merged commit 77e9526 into apache:trunk Sep 18, 2024
@kamalcph kamalcph deleted the KAFKA-17559 branch September 19, 2024 13:54
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
…CancelTask (apache#17214)

Reviewers: David Arthur <mumrah@gmail.com>, Satish Duggana <satishd@apache.org>, Luke Chen <showuon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants