KAFKA-16339: [2/4 KStream#flatTransform] Remove Deprecated "transformer" methods and classes#17245
Merged
mjsax merged 7 commits intoapache:trunkfrom Nov 8, 2024
Conversation
fonsdant
changed the title
Signed-off-by: Joao Pedro Fonseca Dantas <fonsdant@gmail.com>
Signed-off-by: Joao Pedro Fonseca Dantas <fonsdant@gmail.com>
Signed-off-by: Joao Pedro Fonseca Dantas <fonsdant@gmail.com>
Signed-off-by: Joao Pedro Fonseca Dantas <fonsdant@gmail.com>
Signed-off-by: Joao Pedro Fonseca Dantas <fonsdant@gmail.com>
fonsdant
force-pushed
the
kstream-flat-transform-remove-deprecated-transformer-methods-and-classes
branch
from
7ea8ea0 to
cb37065
Compare
Signed-off-by: Joao Pedro Fonseca Dantas <fonsdant@gmail.com>
Signed-off-by: Joao Pedro Fonseca Dantas <fonsdant@gmail.com>
Contributor
Author
|
Hi, @mjsax! I have rebased this branch, removed flatTransform, and refactored where needed. |
mjsax
reviewed
Nov 7, 2024
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
Thanks for update the PR. Overall LGTM. Just one question about rewriting vs removing some tests.
| @SuppressWarnings("deprecation") | ||
| public void shouldNotAllowBadTransformerSupplierOnFlatTransform() { | ||
| final org.apache.kafka.streams.kstream.Transformer<String, String, Iterable<KeyValue<String, String>>> transformer = flatTransformerSupplier.get(); | ||
| public void shouldNotAllowBadProcessSupplierOnProcess() { |
Member
There was a problem hiding this comment.
Is there no existing test for ProcessSupplier to test test case? Just wondering if this rewrite makes sense (and closes a test gap), or if this rewrite would duplicate an existing test (and thus, we could just remove this test instead of rewriting it)?
| @SuppressWarnings("deprecation") | ||
| public void shouldNotAllowBadTransformerSupplierOnFlatTransformWithNamed() { | ||
| final org.apache.kafka.streams.kstream.Transformer<String, String, Iterable<KeyValue<String, String>>> transformer = flatTransformerSupplier.get(); | ||
| public void shouldNotAllowBadProcessSupplierOnProcessWithNamed() { |
| @SuppressWarnings("deprecation") | ||
| public void shouldNotAllowBadTransformerSupplierOnFlatTransformWithNamedAndStores() { | ||
| final org.apache.kafka.streams.kstream.Transformer<String, String, Iterable<KeyValue<String, String>>> transformer = flatTransformerSupplier.get(); | ||
| public void shouldNotAllowBadProcessSupplierOnProcessWithNamedAndStores() { |
Contributor
Author
|
@mjsax, I have refactored only those which seemed not covered yet. To discover them, I have compared all tests referencing process and flatTransform in KStreamImplTest and removed equivalent ones. |
Member
|
Thanks for double checking the tests! Merged to |
Contributor
Author
|
Thanks, Matthias! Two down, two to go 😃 |
fonsdant
deleted the
kstream-flat-transform-remove-deprecated-transformer-methods-and-classes
branch
chiacyu
pushed a commit
to chiacyu/kafka
that referenced
this pull request
Nov 30, 2024
…er" methods and classes (apache#17245) Reviewers: Matthias J. Sax <matthias@confluent.io>
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
…er" methods and classes (apache#17245) Reviewers: Matthias J. Sax <matthias@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has as base the PR: #17198.