Skip to content

HOTFIX: fix failed cases in FeatureCommandTest#17287

Merged
mumrah merged 1 commit intoapache:trunkfrom
FrankYang0529:fix-feature-command-test
Sep 26, 2024
Merged

HOTFIX: fix failed cases in FeatureCommandTest#17287
mumrah merged 1 commit intoapache:trunkfrom
FrankYang0529:fix-feature-command-test

Conversation

@FrankYang0529
Copy link
Copy Markdown
Member

@FrankYang0529 FrankYang0529 commented Sep 26, 2024

CI sample: https://github.com/apache/kafka/actions/runs/11051663030/job/30710832201?pr=17165

FAILED ❌ FeatureCommandTest > testDescribeWithKRaftAndBootstrapControllers [1] Type=Raft-Isolated, MetadataVersion=3.7-IV0,Security=PLAINTEXT
FAILED ❌ FeatureCommandTest > testDowngradeMetadataVersionWithKRaft [1] Type=Raft-Isolated, MetadataVersion=3.3-IV1,Security=PLAINTEXT
FAILED ❌ FeatureCommandTest > testDescribeWithKRaft [1] Type=Raft-Isolated, MetadataVersion=3.3-IV1,Security=PLAINTEXT

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Signed-off-by: PoAn Yang <payang@apache.org>
@github-actions github-actions Bot added tools tests Test fixes (including flaky tests) labels Sep 26, 2024
@chia7712
Copy link
Copy Markdown
Member

The failed test is caused by #17112, which added IBP_4_0_IV3, and the failure is due to the tool-module cache.

@mumrah This is the issue we discussed over the email thread. Perhaps we should always run certain modules to ensure the PR is covered by sufficient integration tests?

@chia7712 chia7712 changed the title MINOR: fix failed cases in FeatureCommandTest HOTFIX: fix failed cases in FeatureCommandTest Sep 26, 2024
@mumrah
Copy link
Copy Markdown
Member

mumrah commented Sep 26, 2024

Looks like the tests were failing on the PR, so this should not have been merged.

https://github.com/apache/kafka/actions/runs/11027485627

@mumrah
Copy link
Copy Markdown
Member

mumrah commented Sep 26, 2024

@chia7712 I agree we should eventually have some "acceptance" tests which do some high level sanity checks. In this case, a change to MetadataVersion (located in server-common) will cause pretty much all tests to run except maybe client.

@chia7712
Copy link
Copy Markdown
Member

Looks like the tests were failing on the PR, so this should not have been merged.

you are right. I was checking the wrong CI :(

Copy link
Copy Markdown
Member

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @FrankYang0529!

@mumrah mumrah merged commit cd4d6ce into apache:trunk Sep 26, 2024
@mumrah
Copy link
Copy Markdown
Member

mumrah commented Sep 26, 2024

I verified that the test is passing locally. Merging now to un-break trunk

@FrankYang0529 FrankYang0529 deleted the fix-feature-command-test branch September 26, 2024 15:24
@kamalcph
Copy link
Copy Markdown
Contributor

Thanks @FrankYang0529 for fixing this test!

airlock-confluentinc Bot pushed a commit to confluentinc/kafka that referenced this pull request Sep 30, 2024
Reviewers: David Arthur <mumrah@gmail.com>
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
Reviewers: David Arthur <mumrah@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Test fixes (including flaky tests) tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants