HOTFIX: fix failed cases in FeatureCommandTest#17287
Merged
mumrah merged 1 commit intoapache:trunkfrom Sep 26, 2024
Merged
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
Member
Member
|
Looks like the tests were failing on the PR, so this should not have been merged. https://github.com/apache/kafka/actions/runs/11027485627 |
Member
|
@chia7712 I agree we should eventually have some "acceptance" tests which do some high level sanity checks. In this case, a change to MetadataVersion (located in server-common) will cause pretty much all tests to run except maybe client. |
Member
you are right. I was checking the wrong CI :( |
mumrah
approved these changes
Sep 26, 2024
Member
mumrah
left a comment
There was a problem hiding this comment.
Thanks for the fix @FrankYang0529!
Member
|
I verified that the test is passing locally. Merging now to un-break trunk |
Contributor
|
Thanks @FrankYang0529 for fixing this test! |
3 tasks
airlock-confluentinc Bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Sep 30, 2024
Reviewers: David Arthur <mumrah@gmail.com>
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
Reviewers: David Arthur <mumrah@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI sample: https://github.com/apache/kafka/actions/runs/11051663030/job/30710832201?pr=17165
Committer Checklist (excluded from commit message)