KAFKA-15859: Fixed the Unsupported version error when new admin connects to old broker

[kamalcph]

Fixed the Unsupported version error when new admin tries to connect to old broker:

org.apache.kafka.common.errors.UnsupportedVersionException: Attempted to write a non-default timeoutMs at version 8

Committer Checklist (excluded from commit message)

• Verify design and implementation
• Verify test coverage and CI build status
• Verify documentation (including upgrade notes)

[kamalcph]

The existing test testCheckEarliestLocalTimestampVersion and testCheckLatestTieredTimestampVersion in ListOffsetsRequestTest seems incorrect to me, it does not assert any behavior.

[showuon]

LGTM!

[showuon]

The existing test testCheckEarliestLocalTimestampVersion and testCheckLatestTieredTimestampVersion in ListOffsetsRequestTest seems incorrect to me, it does not assert any behavior.

They assertThrows UnsupportedVersionException. What do you mean no assertion?

[kamalcph]

The existing test testCheckEarliestLocalTimestampVersion and testCheckLatestTieredTimestampVersion in ListOffsetsRequestTest seems incorrect to me, it does not assert any behavior.

They assertThrows UnsupportedVersionException. What do you mean no assertion?

The test throws unsupported version exception for all versions of LIST_OFFSETS request. If we update the testUnsupportedVersion method as below, then the test still succeeds:

private void testUnsupportedVersion(int version, long timestamp) {
        if (timestamp == EARLIEST_LOCAL_TIMESTAMP) {
            assertUnsupportedVersion(version);
        } else if (timestamp == LATEST_TIERED_TIMESTAMP) {
            assertUnsupportedVersion(version);
        }
    }

I don't understand the purpose of the test.

[chia7712]

@kamalcph thanks for this patch

[chia7712]

Could you please consider adding "ignorable": true to protocol file instead?

[kamalcph]

Thanks for the suggestion! Updated the patch and tested out. It works as expected.

[chia7712]

The test throws unsupported version exception for all versions of LIST_OFFSETS request. If we update the testUnsupportedVersion method as below, then the test still succeeds:

you are right. in the #16876 we want to make sure the minVersion will be changed by the timestamp, those checks are covered by testListOffsetsRequestOldestVersion already. I open https://issues.apache.org/jira/browse/KAFKA-17693 to address it.

[showuon]

@kamalcph , you can try to merge this PR by yourselves now. Let us know if you encounter any problem.

[chia7712]

https://github.com/apache/kafka/blob/trunk/committer-tools/reviewers.py

Please consider leveraging 'reviewers.py' to generate the reviewer list 😃