KAFKA-15859: Complete delayed RemoteListOffsets requests when replica moves away from broker#17487
Merged
junrao merged 2 commits intoapache:trunkfrom Oct 16, 2024
Merged
KAFKA-15859: Complete delayed RemoteListOffsets requests when replica moves away from broker#17487junrao merged 2 commits intoapache:trunkfrom
junrao merged 2 commits intoapache:trunkfrom
Conversation
…ca is removed from broker. - Removed the ListOffsetsMetadata wrapper class. - Addressed review comments from PR apache#16602
kamalcph
changed the title
3 tasks
kamalcph
commented
Oct 12, 2024
| import scala.jdk.CollectionConverters._ | ||
|
|
||
| case class ListOffsetsPartitionStatus(var responseOpt: Option[ListOffsetsPartitionResponse] = None, | ||
| case class ListOffsetsPartitionStatus(@volatile var responseOpt: Option[ListOffsetsPartitionResponse], |
Contributor
Author
There was a problem hiding this comment.
Intellij shows "Class parameter shadows superclass var". How to fix this warning?
Contributor
There was a problem hiding this comment.
Probably this conflicts with the case class. Maybe use a non-case class?
Contributor
Author
There was a problem hiding this comment.
Used a non-case class with object to overcome the warning.
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
… moves away from broker (apache#17487) Removed the ListOffsetsMetadata wrapper class. Complete the response when replica is not a leader. Reviewers: Jun Rao <junrao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)