KAFKA-15995: Adding KIP-877 support to Connect #17804
Merged
mimaison merged 2 commits intoapache:trunkfrom Feb 11, 2025
Merged
Conversation
mimaison
force-pushed
the
kip-877-connect
branch
2 times, most recently
from
e05fab3 to
ba39e3e
Compare
mimaison
force-pushed
the
kip-877-connect
branch
from
ba39e3e to
0d8e11d
Compare
mimaison
force-pushed
the
kip-877-connect
branch
from
0d8e11d to
6241029
Compare
Member
Author
|
This is now ready to review. |
gharris1727
reviewed
Feb 10, 2025
Contributor
gharris1727
left a comment
gharris1727
left a comment
There was a problem hiding this comment.
Thanks @mimaison for the PR! I had some minor comments about the excess surface area of returning Herder and Worker objects when only the metrics are needed.
Merged
3 tasks
gharris1727
approved these changes
Feb 11, 2025
Contributor
gharris1727
left a comment
gharris1727
left a comment
There was a problem hiding this comment.
LGTM, Thanks @mimaison!
Member
Author
|
Thanks for the review! The CI has passed, merging to trunk |
pdruley
pushed a commit
to pdruley/kafka
that referenced
this pull request
Feb 12, 2025
Reviewers: Greg Harris <gharris1727@gmail.com>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
Reviewers: Greg Harris <gharris1727@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on top of #17511, this adds KIP-877 support to Connect
Committer Checklist (excluded from commit message)