Skip to content

MINOR: limit checkStyle memory usage#18071

Merged
mumrah merged 1 commit intoapache:trunkfrom
TaiJuWu:checkStyle
Dec 6, 2024
Merged

MINOR: limit checkStyle memory usage#18071
mumrah merged 1 commit intoapache:trunkfrom
TaiJuWu:checkStyle

Conversation

@TaiJuWu
Copy link
Copy Markdown
Collaborator

@TaiJuWu TaiJuWu commented Dec 6, 2024

see #18067 (comment)
After increasing gradle memory usage, we still meet checkStyle OOM.
We need to limit checkStyle memory usage in gradle.build.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added build Gradle build or GitHub Actions small Small PRs labels Dec 6, 2024
@TaiJuWu TaiJuWu changed the title MINOR: test MINOR: limit checkStyle memory usage Dec 6, 2024
@TaiJuWu TaiJuWu marked this pull request as ready for review December 6, 2024 03:41
Copy link
Copy Markdown
Member

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested it over #18078 and it seems to work.

Thanks @TaiJuWu! LGTM

@mumrah mumrah merged commit c920989 into apache:trunk Dec 6, 2024
@TaiJuWu TaiJuWu deleted the checkStyle branch December 6, 2024 15:48
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
This patch sets the max heap for Checkstyle to 1g to avoid OOM during the CI build

Reviewers: David Arthur <mumrah@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Gradle build or GitHub Actions ci-approved small Small PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants