MINOR: remove old procesor API MockInternalProcessorContext#18103
Merged
mjsax merged 1 commit intoapache:trunkfrom Dec 11, 2024
Merged
Conversation
mjsax
commented
Dec 9, 2024
| buffer.put(streamTime, new Record<>(key, new Change<>(value, null), 0L), recordContext); | ||
| } | ||
|
|
||
| @SuppressWarnings("resource") |
mjsax
commented
Dec 9, 2024
| @ParameterizedTest | ||
| @MethodSource("stores") | ||
| public void shouldRecordCorrectBlockCacheCapacity(final RocksDBStore store, final StateStoreContext ctx) { | ||
| withStore(store, ctx, () -> |
mjsax
commented
Dec 9, 2024
| try (final Cache blockCache = tableFormatConfig.blockCache()) { | ||
| final long usage = blockCache.getUsage(); | ||
| assertMetric(ctx, STATE_STORE_LEVEL_GROUP, RocksDBMetrics.USAGE_OF_BLOCK_CACHE, BigInteger.valueOf(usage)); | ||
| } |
mjsax
commented
Dec 9, 2024
| try (final Cache blockCache = tableFormatConfig.blockCache()) { | ||
| final long usage = blockCache.getPinnedUsage(); | ||
| assertMetric(ctx, STATE_STORE_LEVEL_GROUP, RocksDBMetrics.PINNED_USAGE_OF_BLOCK_CACHE, BigInteger.valueOf(usage)); | ||
| } |
mjsax
commented
Dec 9, 2024
| }); | ||
| } | ||
|
|
||
| @SuppressWarnings("resource") |
mjsax
commented
Dec 9, 2024
|
|
||
| private ProcessorNode currentNode; | ||
| private ProcessorNode<?, ?, ?, ?> currentNode; | ||
| private RecordCollector recordCollector; |
Member
Author
There was a problem hiding this comment.
Add missing recordCollector "feature -- the old MockInternalProcessorContext that we remove with this PR had this, and the test we rewrite use this feature
mjsax
commented
Dec 9, 2024
| private ProcessorNode currentNode; | ||
| private ProcessorNode<?, ?, ?, ?> currentNode; | ||
| private RecordCollector recordCollector; | ||
| private final Map<String, StateRestoreCallback> restoreCallbacks = new LinkedHashMap<>(); |
mjsax
commented
Dec 9, 2024
|
|
||
| @Override | ||
| public void setCurrentNode(final ProcessorNode currentNode) { | ||
| public void setCurrentNode(final ProcessorNode<?, ?, ?, ?> currentNode) { |
peterxcli
pushed a commit
to peterxcli/kafka
that referenced
this pull request
Dec 18, 2024
…8103) Reviewers: Bill Bejeck <bill@confluent.io>
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
…8103) Reviewers: Bill Bejeck <bill@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.