Skip to content

Kafka-16540: Update partitions if min isr config is changed.#18148

Merged
cmccabe merged 12 commits intoapache:trunkfrom
CalvinLiu7947:ELR-config-update-3
Jan 24, 2025
Merged

Kafka-16540: Update partitions if min isr config is changed.#18148
cmccabe merged 12 commits intoapache:trunkfrom
CalvinLiu7947:ELR-config-update-3

Conversation

@CalvinLiu7947
Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/KAFKA-16540
If the min isr config is changed, we need to update the partitions with ELR if possible.

@CalvinLiu7947 CalvinLiu7947 marked this pull request as ready for review December 11, 2024 22:06
@github-actions github-actions Bot added triage PRs from the community kraft labels Dec 11, 2024
@github-actions
Copy link
Copy Markdown

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@github-actions
Copy link
Copy Markdown

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

Comment thread metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java Outdated
@github-actions github-actions Bot added the core Kafka Broker label Jan 11, 2025
@github-actions github-actions Bot removed triage PRs from the community needs-attention labels Jan 11, 2025
setFeatureControl(featureControl).
setExistenceChecker(resourceExists).
setAlterConfigPolicy(alterConfigPolicy).
setValidator(configurationValidator).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this doesn't need to be changed :)

Can leave the setFeatureControl on the line it was previously :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@CalvinLiu7947 CalvinLiu7947 requested a review from cmccabe January 23, 2025 16:25
Copy link
Copy Markdown
Contributor

@cmccabe cmccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending Jenkins.

@cmccabe cmccabe merged commit 6235a73 into apache:trunk Jan 24, 2025
pranavt84 pushed a commit to pranavt84/kafka that referenced this pull request Jan 27, 2025
…18148)

In order to maintain the integrity of replication, we need to clear the ELRs of affected partitions when min.insync.replicas is changed. This could happen at the topic level, or at a global level if the cluster level default is changed.

Reviewers: Colin P. McCabe <cmccabe@apache.org>
airlock-confluentinc Bot pushed a commit to confluentinc/kafka that referenced this pull request Jan 27, 2025
…18148)

In order to maintain the integrity of replication, we need to clear the ELRs of affected partitions when min.insync.replicas is changed. This could happen at the topic level, or at a global level if the cluster level default is changed.

Reviewers: Colin P. McCabe <cmccabe@apache.org>
cmccabe pushed a commit that referenced this pull request Feb 4, 2025
In order to maintain the integrity of replication, we need to clear the ELRs of affected partitions when min.insync.replicas is changed. This could happen at the topic level, or at a global level if the cluster level default is changed.

Reviewers: Colin P. McCabe <cmccabe@apache.org>
pdruley pushed a commit to pdruley/kafka that referenced this pull request Feb 12, 2025
…18148)

In order to maintain the integrity of replication, we need to clear the ELRs of affected partitions when min.insync.replicas is changed. This could happen at the topic level, or at a global level if the cluster level default is changed.

Reviewers: Colin P. McCabe <cmccabe@apache.org>
manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025
…18148)

In order to maintain the integrity of replication, we need to clear the ELRs of affected partitions when min.insync.replicas is changed. This could happen at the topic level, or at a global level if the cluster level default is changed.

Reviewers: Colin P. McCabe <cmccabe@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Kafka Broker kraft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants