Skip to content

[DO NOT MERGE] Experimentally change consumer topic auto-create default#18164

Closed
AndrewJSchofield wants to merge 1 commit intoapache:trunkfrom
AndrewJSchofield:consumer-disable-auto-create-experiment
Closed

[DO NOT MERGE] Experimentally change consumer topic auto-create default#18164
AndrewJSchofield wants to merge 1 commit intoapache:trunkfrom
AndrewJSchofield:consumer-disable-auto-create-experiment

Conversation

@AndrewJSchofield
Copy link
Copy Markdown
Member

KIP-361 introduced a consumer config allow.auto.create.topics which enables a consumer subscribing to a non-existent topic to create it automatically. Initially, it defaulted to true, but the eventual plan was to change the default to false. This PR changes the default.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community consumer clients small Small PRs labels Dec 13, 2024
@mumrah
Copy link
Copy Markdown
Member

mumrah commented Dec 13, 2024

@AndrewJSchofield #17881 adds a "triage" label to PRs from non-committers. Turns out this also affect committers if their membership visibility in the ASF GitHub org is not public. I added instructions for setting your membership visibility to public https://github.com/apache/kafka/blob/trunk/.github/workflows/README.md#pr-triage

@AndrewJSchofield AndrewJSchofield removed the triage PRs from the community label Dec 14, 2024
@AndrewJSchofield
Copy link
Copy Markdown
Member Author

10 failed tests due to changed default:

  • FAILED ❌ AuthorizerIntegrationTest > testCreatePermissionOnClusterToReadFromNonExistentTopic(String, String).quorum=kraft.groupProtocol=classic
  • FAILED ❌ AuthorizerIntegrationTest > testCreatePermissionOnClusterToReadFromNonExistentTopic(String, String).quorum=kraft.groupProtocol=consumer
  • FAILED ❌ AuthorizerIntegrationTest > testCreatePermissionOnTopicToReadFromNonExistentTopic(String, String).quorum=kraft.groupProtocol=classic
  • FAILED ❌ AuthorizerIntegrationTest > testCreatePermissionOnTopicToReadFromNonExistentTopic(String, String).quorum=kraft.groupProtocol=consumer
  • FAILED ❌ PlaintextConsumerTest > testPartitionsForAutoCreate(String, String).quorum=kraft.groupProtocol=classic
  • FAILED ❌ PlaintextConsumerTest > testPartitionsForAutoCreate(String, String).quorum=kraft.groupProtocol=consumer
  • FAILED ❌ PlaintextAdminIntegrationTest > testConsumeAfterDeleteRecords(String, String).quorum=kraft.groupProtocol=classic
  • FAILED ❌ PlaintextAdminIntegrationTest > testConsumeAfterDeleteRecords(String, String).quorum=kraft.groupProtocol=consumer
  • FAILED ❌ PlaintextAdminIntegrationTest > testDeleteRecordsWithException(String, String).quorum=kraft.groupProtocol=classic
  • FAILED ❌ PlaintextAdminIntegrationTest > testDeleteRecordsWithException(String, String).quorum=kraft.groupProtocol=consumer

@AndrewJSchofield AndrewJSchofield deleted the consumer-disable-auto-create-experiment branch December 16, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants