Skip to content

MINOR: Fix flaky state updater test #18253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cadonna merged 1 commit into from
Dec 19, 2024
+10 −2
Merged

MINOR: Fix flaky state updater test #18253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ private KafkaFutureImpl<Uuid> restoreConsumerInstanceId(final Duration timeout)


private void handleRuntimeException(final RuntimeException runtimeException) {
log.error("An unexpected error occurred within the state updater thread: " + runtimeException);
log.error("An unexpected error occurred within the state updater thread: {}", String.valueOf(runtimeException));
Copy link
Copy Markdown
Member Author

@cadonna cadonna Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix on the side.

addToExceptionsAndFailedTasksThenClearUpdatingAndPausedTasks(runtimeException);
isRunning.set(false);
}
Expand Down
10 changes: 9 additions & 1 deletion ...s/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,11 @@ private void shouldThrowIfAddingTasksWithSameId(final Task task1, final Task tas
stateUpdater.add(task2);

verifyFailedTasks(IllegalStateException.class, task1);
assertFalse(stateUpdater.isRunning());
waitForCondition(
() -> !stateUpdater.isRunning(),
VERIFICATION_TIMEOUT,
"Did not switch to non-running within the given timeout!"
);
}

@Test
Expand Down Expand Up @@ -1015,6 +1019,8 @@ public void shouldPauseActiveTaskAndTransitToUpdateStandby() throws Exception {
verifyRestoredActiveTasks();
verifyUpdatingTasks(task2);
verifyExceptionsAndFailedTasks();
// shutdown ensures that the test does not end before changelog reader methods verified below are called
stateUpdater.shutdown(Duration.ofMinutes(1));
verify(changelogReader, times(1)).enforceRestoreActive();
verify(changelogReader, times(1)).transitToUpdateStandby();
}
Expand Down Expand Up @@ -1152,6 +1158,8 @@ public void shouldIdleWhenAllTasksPaused() throws Exception {
public void shouldResumeStandbyTask() throws Exception {
final StandbyTask task = standbyTask(TASK_0_0, Set.of(TOPIC_PARTITION_A_0)).inState(State.RUNNING).build();
shouldResumeStatefulTask(task);
// shutdown ensures that the test does not end before changelog reader methods verified below are called
stateUpdater.shutdown(Duration.ofMinutes(1));
verify(changelogReader, times(2)).transitToUpdateStandby();
}

Expand Down