Skip to content

KAFKA-18343: Use java_pids to implement pids #18312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jolshan merged 1 commit into from
Dec 24, 2024
Merged

KAFKA-18343: Use java_pids to implement pids #18312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions tests/kafkatest/services/kafka/kafka.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,9 +951,7 @@ def run_features_command(self, op, feature, new_version):
def pids(self, node):
"""Return process ids associated with running processes on the given node."""
try:
cmd = "ps ax | grep -i %s | grep -v grep | awk '{print $1}'" % self.java_class_name()
pid_arr = [pid for pid in node.account.ssh_capture(cmd, allow_fail=True, callback=int)]
return pid_arr
return node.account.java_pids(self.java_class_name())
except (RemoteCommandError, ValueError) as e:
return []

Expand Down Expand Up @@ -1935,4 +1933,4 @@ def get_offset_shell(self, time=None, topic=None, partitions=None, topic_partiti
return output

def java_class_name(self):
return "kafka.Kafka"
return "kafka\.Kafka"