Skip to content

KAFKA-18403: Check all dynamic properites, which can't support in KRaft#18390

Closed
m1a2st wants to merge 2 commits intoapache:trunkfrom
m1a2st:KAFKA-18403
Closed

KAFKA-18403: Check all dynamic properites, which can't support in KRaft#18390
m1a2st wants to merge 2 commits intoapache:trunkfrom
m1a2st:KAFKA-18403

Conversation

@m1a2st
Copy link
Copy Markdown
Collaborator

@m1a2st m1a2st commented Jan 5, 2025

Jira: https://issues.apache.org/jira/browse/KAFKA-18403

I testing all dynamic config, only ADVERTISED_LISTENERS_CONFIG can't dynamic change in Kraft, thus I remove it from dynamic config list, but I still remain ADVERTISED_LISTENERS_CONFIG check in reconfig.

private def verifyListenerRegistrationAlterationSupported(): Unit = {

Test in my local machine

<li>
    <h4><a id="advertised.listeners"></a><a id="brokerconfigs_advertised.listeners"
                                            href="#brokerconfigs_advertised.listeners">advertised.listeners</a></h4>
    <p>Specifies the listener ...</p>
    <table>
        <tbody>
        <tr>
            <th>Type:</th>
            <td>string</td>
        </tr>
        <tr>
            <th>Default:</th>
            <td>null</td>
        </tr>
        <tr>
            <th>Valid Values:</th>
            <td></td>
        </tr>
        <tr>
            <th>Importance:</th>
            <td>high</td>
        </tr>
        <tr>
            <th>Update Mode:</th>
            <td>read-only</td>
        </tr>
        </tbody>
    </table>
</li>

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions Bot added triage PRs from the community core Kafka Broker small Small PRs labels Jan 5, 2025
@m1a2st m1a2st mentioned this pull request Jan 5, 2025
3 tasks
@github-actions
Copy link
Copy Markdown

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@m1a2st m1a2st closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-approved core Kafka Broker needs-attention small Small PRs triage PRs from the community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants