KAFKA-18434: enrich the authorization error message of connecting to controller#18436
Merged
divijvaidya merged 1 commit intoapache:trunkfrom Jan 8, 2025
Merged
KAFKA-18434: enrich the authorization error message of connecting to controller#18436divijvaidya merged 1 commit intoapache:trunkfrom
divijvaidya merged 1 commit intoapache:trunkfrom
Conversation
divijvaidya
reviewed
Jan 8, 2025
| } | ||
| // Unlike on the broker, DESCRIBE_CLUSTER on the controller requires a high level of | ||
| // permissions (ALTER on CLUSTER). | ||
| authHelper.authorizeClusterOperation(request, ALTER) |
Member
There was a problem hiding this comment.
Unrelated to this PR but probably good to have. Could we update authorizeClusterOperation to log the missing permission as well in the exception.
Member
Author
There was a problem hiding this comment.
Thanks for review 😄.
…controller Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
KAFKA-18434
branch
from
ff07133 to
d1f981e
Compare
divijvaidya
approved these changes
Jan 8, 2025
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
…controller (apache#18436) Reviewers: Divij Vaidya <diviv@amazon.com>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
…controller (apache#18436) Reviewers: Divij Vaidya <diviv@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE_CLUSTER request needs ALTER permission when connecting to controller. However, the error message does not include the reason. There is a good explanation in the origin PR (#14306 (comment)) and we should add it to the exception message.
Committer Checklist (excluded from commit message)