KAFKA-18399: Remove ZooKeeper from KafkaApis (4/N): OFFSET_COMMIT and OFFSET_FETCH#18461
KAFKA-18399: Remove ZooKeeper from KafkaApis (4/N): OFFSET_COMMIT and OFFSET_FETCH#18461chia7712 merged 1 commit intoapache:trunkfrom
Conversation
| authorizedTopicsRequest, | ||
| responseBuilder | ||
| ) | ||
| requestHelper.sendMaybeThrottle(request, offsetCommitRequest.getErrorResponse(Errors.UNSUPPORTED_VERSION.exception)) |
There was a problem hiding this comment.
I think that we removed version 0 of that API so we could remove the entire branch.
| requestHelper.sendMaybeThrottle(request, request.body[OffsetFetchRequest].getErrorResponse(Errors.UNSUPPORTED_VERSION.exception)) | ||
| CompletableFuture.completedFuture(()) |
There was a problem hiding this comment.
Updated it. Thanks for the review.
FrankYang0529
force-pushed
the
KAFKA-18399
branch
2 times, most recently
from
4a7fdc2 to
1a4760a
Compare
|
The failed case |
…T_FETCH Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
KAFKA-18399
branch
from
1a4760a to
e5503fc
Compare
chia7712
changed the title
…OFFSET_FETCH (#18461) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
|
@chia7712 You could have mentioned me as a reviewer on this one. Any reason why you did not? |
I have verified that all your comments have been addressed. Merging this PR can facilitate the progress of other ZK-related code cleanups. We can address any remaining feedback in subsequent PRs, such as those related to other cleanups. However, this is my perspective. I will await your second review next time. |
|
@chia7712 It is totally fine to merge it. I was referring to the reviewers in the commit message: |
that is my fault. I should not merge PR after working over 24 hours :( |
…OFFSET_FETCH (apache#18461) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
…OFFSET_FETCH (apache#18461) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
…OFFSET_FETCH (apache#18461) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
3 participants
JIRA: https://issues.apache.org/jira/browse/KAFKA-18399
Remove ZK support for OFFSET_COMMIT and OFFSET_FETCH.
Committer Checklist (excluded from commit message)