KAFKA-18479: RocksDBTimeOrderedKeyValueBuffer not initialized correctly#18490
Merged
mjsax merged 2 commits intoapache:trunkfrom Jan 15, 2025
Merged
KAFKA-18479: RocksDBTimeOrderedKeyValueBuffer not initialized correctly#18490mjsax merged 2 commits intoapache:trunkfrom
mjsax merged 2 commits intoapache:trunkfrom
Conversation
RocksDBTimeOrderedKeyValueBuffer is not initialize with serdes provides via Joined, but always uses serdes from StreamsConfig.
mjsax
commented
Jan 11, 2025
|
|
||
| final KeyValueIterator<Long, ValueAndTimestamp<String>> all = store.all(); | ||
| final KeyValue<Long, ValueAndTimestamp<String>> onlyEntry = all.next(); | ||
| try (final KeyValueIterator<Long, ValueAndTimestamp<String>> all = store.all()) { |
mjsax
commented
Jan 11, 2025
| final KTable<Long, String> rightTable = builder.table(INPUT_TOPIC_RIGHT, Consumed.with(Serdes.Long(), Serdes.String()), Materialized.as( | ||
| Stores.persistentVersionedKeyValueStore(STORE_NAME, Duration.ofMinutes(5)))); | ||
| final Properties streamsConfig = setupConfigsAndUtils(cacheEnabled); | ||
| final Properties streamsConfig = setupConfigsAndUtils(cacheEnabled, false); |
Member
Author
There was a problem hiding this comment.
To test Joined we use false here
mjsax
commented
Jan 11, 2025
| final KTable<Long, String> rightTable = builder.table(INPUT_TOPIC_RIGHT, Materialized.as( | ||
| Stores.persistentVersionedKeyValueStore(STORE_NAME, Duration.ofMinutes(5)))); | ||
| final Properties streamsConfig = setupConfigsAndUtils(cacheEnabled); | ||
| final Properties streamsConfig = setupConfigsAndUtils(cacheEnabled, true); |
Member
Author
There was a problem hiding this comment.
For leftJoin we stick with using StreamsConfig serde to test both setups.
mjsax
commented
Jan 11, 2025
| } | ||
|
|
||
| private void createBuffer(final Duration grace) { | ||
| private void createBuffer(final Duration grace, final Serde<String> serde) { |
Member
Author
There was a problem hiding this comment.
"randomizing" this test, to cover both code path.
mjsax
added a commit
that referenced
this pull request
Jan 15, 2025
…ly (#18490) RocksDBTimeOrderedKeyValueBuffer is not initialize with serdes provides via Joined, but always uses serdes from StreamsConfig. Reviewers: Bill Bejeck <bill@confluent.io>
mjsax
added a commit
that referenced
this pull request
Jan 15, 2025
…ly (#18490) RocksDBTimeOrderedKeyValueBuffer is not initialize with serdes provides via Joined, but always uses serdes from StreamsConfig. Reviewers: Bill Bejeck <bill@confluent.io>
mjsax
added a commit
to mjsax/kafka
that referenced
this pull request
Jan 15, 2025
…ly (apache#18490) RocksDBTimeOrderedKeyValueBuffer is not initialize with serdes provides via Joined, but always uses serdes from StreamsConfig. Reviewers: Bill Bejeck <bill@confluent.io>
Member
Author
|
Merged to |
chia7712
reviewed
Jan 16, 2025
| @@ -62,18 +62,16 @@ public class RocksDBTimeOrderedKeyValueBufferTest { | |||
| @SuppressWarnings({"rawtypes", "unchecked"}) | |||
Member
There was a problem hiding this comment.
Sorry for the delayed feedback. To address the following warnings, could you please move these suppression annotations to the class-level?
> Task :streams:compileTestJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /home/chia7712/project/kafka/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBufferTest.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Member
Author
There was a problem hiding this comment.
Nice catch! -- I think we should never use class level suppression though. Opened a PR to suppress for the individual methods: #18580
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
…ly (apache#18490) RocksDBTimeOrderedKeyValueBuffer is not initialize with serdes provides via Joined, but always uses serdes from StreamsConfig. Reviewers: Bill Bejeck <bill@confluent.io>
airlock-confluentinc Bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
…ly (apache#18490) RocksDBTimeOrderedKeyValueBuffer is not initialize with serdes provides via Joined, but always uses serdes from StreamsConfig. Reviewers: Bill Bejeck <bill@confluent.io>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
…ly (apache#18490) RocksDBTimeOrderedKeyValueBuffer is not initialize with serdes provides via Joined, but always uses serdes from StreamsConfig. Reviewers: Bill Bejeck <bill@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RocksDBTimeOrderedKeyValueBuffer is not initialize with serdes provides via Joined, but always uses serdes from StreamsConfig.