KAFKA-18483: Disable Log4jController and Loggers if Log4j Core absent

[ppkarwasz]

If Log4j Core is absent, most calls to Log4jController and Loggers will end up with a NoClassDefFoundError.

This changeset:

• Profits from the major version bump to rename k.util.Log4jController to LoggingController.
• Removes o.a.l.l.Level from the signature of public methods of o.a.k.connect.runtime.Loggers and replaces it with String.
• Provides an additional no-op implementation of k.util.LoggingController and o.a.k.connect.runtime.Loggers: if Log4j Core is not present on the runtime classpath the no-op implementation will be used.

Committer Checklist (excluded from commit message)

• Verify design and implementation
• Verify test coverage and CI build status
• Verify documentation (including upgrade notes)

[chia7712]

@ppkarwasz could you please fix the conflicts? I will get a quick review after the conflicts get fixed.

[github-actions]

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

[ppkarwasz]

@ppkarwasz could you please fix the conflicts? I will get a quick review after the conflicts get fixed.

Sure, I'll fix the conflicts and check out the failing tests today.

[github-actions]

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

[ppkarwasz]

Note: Before submitting the PR I checked it with ./gradlew test using JDK 17. I am not sure why it fails on the CI.

[chia7712]

Before submitting the PR I checked it with ./gradlew test using JDK 17. I am not sure why it fails on the CI.

there are some flaky test in trunk branch. I feel they are unrelated to this PR :)

[mimaison]

I hit the test failure locally when on your branch:

./gradlew core:test --tests "*LoggingTest"

> Task :core:test

Gradle Test Run :core:test > Gradle Test Executor 10 > LoggingTest > testLoggerLevelIsResolved() PASSED
kafka.utils.LoggingTest.testLog4jControllerIsRegistered() failed, log available in /Users/mickael/github/kafka/core/build/reports/testOutput/kafka.utils.LoggingTest.testLog4jControllerIsRegistered().test.stdout

Gradle Test Run :core:test > Gradle Test Executor 10 > LoggingTest > testLog4jControllerIsRegistered() FAILED
    org.opentest4j.AssertionFailedError: kafka.utils.Log4jController is not registered ==> expected: <true> but was: <false>
        at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
        at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
        at app//org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
        at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
        at app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
        at app//kafka.utils.LoggingTest.testLog4jControllerIsRegistered(LoggingTest.scala:42)

Gradle Test Run :core:test > Gradle Test Executor 10 > LoggingTest > testTypeOfGetLoggers() PASSED

Gradle Test Run :core:test > Gradle Test Executor 10 > LoggingTest > testLogName() PASSED

Gradle Test Run :core:test > Gradle Test Executor 10 > LoggingTest > testLogNameOverride() PASSED

5 tests completed, 1 failed

[ppkarwasz]

I hit the test failure locally when on your branch:

./gradlew core:test --tests "*LoggingTest"

Thanks somehow Gradle didn't mark the build as failed, even if this test didn't work. Fixed in b382950

[chia7712]

@ppkarwasz thanks for the patch! Sorry for the late review, I was busy with the Lunar New Year festivities :(

[chia7712]

@ppkarwasz Could you please fix the conflicts ?

[chia7712]

LGTM

Test the patch on my local with JMC and changing the logger levels works well.