KAFAK-18451: Flaky RemoteLogManagerTest#testRLMOpsWhenMetadataIsNotReady#18520
Merged
showuon merged 2 commits intoapache:trunkfrom Jan 15, 2025
Merged
KAFAK-18451: Flaky RemoteLogManagerTest#testRLMOpsWhenMetadataIsNotReady#18520showuon merged 2 commits intoapache:trunkfrom
showuon merged 2 commits intoapache:trunkfrom
Conversation
github-actions
Bot
added
core
showuon
reviewed
Jan 14, 2025
Member
showuon
left a comment
showuon
left a comment
There was a problem hiding this comment.
LGTM, a minor comment left. Thanks for the fix!
Comment on lines
3718
to
3720
| doReturn(true).when(remoteLogMetadataManager).isReady(any(TopicIdPartition.class)); | ||
|
|
||
| CountDownLatch latch = new CountDownLatch(3); // there are 3 RLMTasks, so setting the count to 3 | ||
| when(remoteLogMetadataManager.isReady(any(TopicIdPartition.class))) |
Member
There was a problem hiding this comment.
I think L3718 is not needed because we want to use the mock in L3721, right?
Member
Author
There was a problem hiding this comment.
Yes, I just copied and pasted setup function and didn't notice that. Thanks for catching it.
| }; | ||
| doReturn(true).when(remoteLogMetadataManager).isReady(any(TopicIdPartition.class)); | ||
|
|
||
| CountDownLatch latch = new CountDownLatch(3); // there are 3 RLMTasks, so setting the count to 3 |
Signed-off-by: PoAn Yang <payang@apache.org>
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
KAFKA-18451
branch
from
84e5a8a to
17102e1
Compare
3 tasks
Member
|
Re-running CI. |
Member
Author
|
Hi @showuon, thanks for trigger CI again. There are some flaky test cases which are not related to this PR. I can't reproduce on my laptop as well.
|
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
…ady (apache#18520) The REMOTE_LOG_MANAGER_TASK_INTERVAL_MS_PROP in RemoteLogManagerTest is 100 which is too small. If assertions verifyNoMoreInteractions can't run in 100ms, the scheduler will run RLMTask again and the case will fail. Reviewers: Luke Chen <showuon@gmail.com>
airlock-confluentinc Bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
…ady (apache#18520) The REMOTE_LOG_MANAGER_TASK_INTERVAL_MS_PROP in RemoteLogManagerTest is 100 which is too small. If assertions verifyNoMoreInteractions can't run in 100ms, the scheduler will run RLMTask again and the case will fail. Reviewers: Luke Chen <showuon@gmail.com>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
…ady (apache#18520) The REMOTE_LOG_MANAGER_TASK_INTERVAL_MS_PROP in RemoteLogManagerTest is 100 which is too small. If assertions verifyNoMoreInteractions can't run in 100ms, the scheduler will run RLMTask again and the case will fail. Reviewers: Luke Chen <showuon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
REMOTE_LOG_MANAGER_TASK_INTERVAL_MS_PROPinRemoteLogManagerTestis 100 which is too small. If assertionsverifyNoMoreInteractionscan't run in 100ms, the scheduler will runRLMTaskagain and the case will fail.Committer Checklist (excluded from commit message)