Skip to content

Revert "KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors (#18050)"#18544

Merged
showuon merged 1 commit intoapache:trunkfrom
ijuma:revert-kafka-18034-broken-build
Jan 15, 2025
Merged

Revert "KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors (#18050)"#18544
showuon merged 1 commit intoapache:trunkfrom
ijuma:revert-kafka-18034-broken-build

Conversation

@ijuma
Copy link
Copy Markdown
Member

@ijuma ijuma commented Jan 15, 2025

This reverts commit 70d6312.

The tests timed out in #18050 and the same has been happening in trunk since.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Jan 15, 2025

Besides the screenshot in #18050, you can also see that the build was last green just before the relevant commit was merged:

image

Copy link
Copy Markdown
Member

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating it!

@showuon showuon merged commit f3a9355 into apache:trunk Jan 15, 2025
@showuon
Copy link
Copy Markdown
Member

showuon commented Jan 15, 2025

CI all passed. Merged.

@kirktrue kirktrue added KIP-848 The Next Generation of the Consumer Rebalance Protocol ctr Consumer Threading Refactor (KIP-848) labels Jan 17, 2025
pranavt84 pushed a commit to pranavt84/kafka that referenced this pull request Jan 27, 2025
…s on fatal coordinator errors (apache#18050)" (apache#18544)

This reverts commit 70d6312.

Reviewers: Luke Chen <showuon@gmail.com>
airlock-confluentinc Bot pushed a commit to confluentinc/kafka that referenced this pull request Jan 27, 2025
…s on fatal coordinator errors (apache#18050)" (apache#18544)

This reverts commit 70d6312.

Reviewers: Luke Chen <showuon@gmail.com>
manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025
…s on fatal coordinator errors (apache#18050)" (apache#18544)

This reverts commit 70d6312.

Reviewers: Luke Chen <showuon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clients consumer core Kafka Broker ctr Consumer Threading Refactor (KIP-848) KIP-848 The Next Generation of the Consumer Rebalance Protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants