HOTFIX: ClientUtilsTest#testParseAndValidateAddressesWithReverseLookup#18549
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
a551ee6 to
29a02cb
Compare
frankvicky
left a comment
There was a problem hiding this comment.
Apply this patch on my local machine and it works fine.
LGTM
ijuma
left a comment
There was a problem hiding this comment.
LGTM if CI passes. We really need to change this test to use a mock.
Create a follow-up for it. |
|
I am going to cherry-pick this change to all active branches (3.8, 3.9, 4.0) |
#18549) Reviewers: Ismael Juma <ismael@juma.me.uk>, Gaurav Narula <gaurav_narula2@apple.com>, TengYao Chi <kitingiao@gmail.com>
#18549) Reviewers: Ismael Juma <ismael@juma.me.uk>, Gaurav Narula <gaurav_narula2@apple.com>, TengYao Chi <kitingiao@gmail.com>
#18549) Reviewers: Ismael Juma <ismael@juma.me.uk>, Gaurav Narula <gaurav_narula2@apple.com>, TengYao Chi <kitingiao@gmail.com>
|
@divijvaidya -- Seems this cherry-pick did break Pushed a fix into both branches already. So no action needed.
Just a reminder, especially as we dropped Java8, we need to switch Java version when switching branches, so compiling cherry-pick locally is even more important now than it was before. |
|
I understand. Sorry about that @mjsax. |
|
I'd say running |
apache#18549) Reviewers: Ismael Juma <ismael@juma.me.uk>, Gaurav Narula <gaurav_narula2@apple.com>, TengYao Chi <kitingiao@gmail.com>
apache#18549) Reviewers: Ismael Juma <ismael@juma.me.uk>, Gaurav Narula <gaurav_narula2@apple.com>, TengYao Chi <kitingiao@gmail.com>
apache#18549) Reviewers: Ismael Juma <ismael@juma.me.uk>, Gaurav Narula <gaurav_narula2@apple.com>, TengYao Chi <kitingiao@gmail.com>
It looks like "example.com" changes IP again. Change to latest expected result.
Committer Checklist (excluded from commit message)