Skip to content

HOTFIX: ClientUtilsTest#testParseAndValidateAddressesWithReverseLookup#18549

Merged
divijvaidya merged 1 commit intoapache:trunkfrom
FrankYang0529:hotfix-testParseAndValidateAddressesWithReverseLookup
Jan 15, 2025
Merged

HOTFIX: ClientUtilsTest#testParseAndValidateAddressesWithReverseLookup#18549
divijvaidya merged 1 commit intoapache:trunkfrom
FrankYang0529:hotfix-testParseAndValidateAddressesWithReverseLookup

Conversation

@FrankYang0529
Copy link
Copy Markdown
Member

It looks like "example.com" changes IP again. Change to latest expected result.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Copy Markdown
Contributor

@gaurav-narula gaurav-narula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@frankvicky frankvicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply this patch on my local machine and it works fine.
LGTM

Copy link
Copy Markdown
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes. We really need to change this test to use a mock.

@FrankYang0529
Copy link
Copy Markdown
Member Author

We really need to change this test to use a mock.

Create a follow-up for it.
https://issues.apache.org/jira/browse/KAFKA-18546

@divijvaidya divijvaidya added the backport-candidate This pull request is a candidate to be backported to previous versions label Jan 15, 2025
@divijvaidya divijvaidya merged commit 85d2e90 into apache:trunk Jan 15, 2025
@FrankYang0529 FrankYang0529 deleted the hotfix-testParseAndValidateAddressesWithReverseLookup branch January 15, 2025 15:13
@divijvaidya
Copy link
Copy Markdown
Member

I am going to cherry-pick this change to all active branches (3.8, 3.9, 4.0)

divijvaidya pushed a commit that referenced this pull request Jan 15, 2025
#18549)

Reviewers: Ismael Juma <ismael@juma.me.uk>, Gaurav Narula <gaurav_narula2@apple.com>, TengYao Chi <kitingiao@gmail.com>
divijvaidya pushed a commit that referenced this pull request Jan 15, 2025
#18549)

Reviewers: Ismael Juma <ismael@juma.me.uk>, Gaurav Narula <gaurav_narula2@apple.com>, TengYao Chi <kitingiao@gmail.com>
divijvaidya pushed a commit that referenced this pull request Jan 15, 2025
#18549)

Reviewers: Ismael Juma <ismael@juma.me.uk>, Gaurav Narula <gaurav_narula2@apple.com>, TengYao Chi <kitingiao@gmail.com>
@mjsax
Copy link
Copy Markdown
Member

mjsax commented Jan 15, 2025

@divijvaidya -- Seems this cherry-pick did break 3.9 and 3.8 branches.

Pushed a fix into both branches already. So no action needed.

List.of is not supported in Java8... Please compile locally (ideally even run related unit/integration tests) before pushing cherry-picks to older branches.

Just a reminder, especially as we dropped Java8, we need to switch Java version when switching branches, so compiling cherry-pick locally is even more important now than it was before.

@divijvaidya
Copy link
Copy Markdown
Member

I understand. Sorry about that @mjsax.

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Jan 16, 2025

I'd say running ./gradlew check -x test for clean cherry-picks is usually enough. It will do the right thing when it comes to Java support automatically.

pranavt84 pushed a commit to pranavt84/kafka that referenced this pull request Jan 27, 2025
apache#18549)

Reviewers: Ismael Juma <ismael@juma.me.uk>, Gaurav Narula <gaurav_narula2@apple.com>, TengYao Chi <kitingiao@gmail.com>
airlock-confluentinc Bot pushed a commit to confluentinc/kafka that referenced this pull request Jan 27, 2025
apache#18549)

Reviewers: Ismael Juma <ismael@juma.me.uk>, Gaurav Narula <gaurav_narula2@apple.com>, TengYao Chi <kitingiao@gmail.com>
manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025
apache#18549)

Reviewers: Ismael Juma <ismael@juma.me.uk>, Gaurav Narula <gaurav_narula2@apple.com>, TengYao Chi <kitingiao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-candidate This pull request is a candidate to be backported to previous versions clients small Small PRs tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants