Skip to content

MINOR: change warning suppression in RocksDBTimeOrderedKeyValueBufferTest #18580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjsax merged 1 commit into from
Jan 16, 2025
Merged

MINOR: change warning suppression in RocksDBTimeOrderedKeyValueBufferTest #18580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...t/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBufferTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ public class RocksDBTimeOrderedKeyValueBufferTest {
public Sensor sensor;
public long offset;

@SuppressWarnings({"rawtypes", "unchecked"})
@BeforeEach
public void setUp() {
final Metrics metrics = new Metrics();
Expand All @@ -82,6 +81,7 @@ private boolean pipeRecord(final String key, final String value, final long time
return buffer.put(time, record, context.recordContext());
}

@SuppressWarnings({"rawtypes", "unchecked"})
@Test
public void shouldReturnIfRecordWasAdded() {
when(serdeGetter.keySerde()).thenReturn((Serde) new Serdes.StringSerde());
Expand Down Expand Up @@ -112,6 +112,7 @@ public void shouldAddAndEvictRecord() {
assertThat(count.get(), equalTo(1));
}

@SuppressWarnings({"rawtypes", "unchecked"})
@Test
public void shouldAddAndEvictRecordTwice() {
when(serdeGetter.keySerde()).thenReturn((Serde) new Serdes.StringSerde());
Expand Down Expand Up @@ -144,6 +145,7 @@ public void shouldAddAndEvictRecordTwiceWithNonZeroGrace() {
assertThat(count.get(), equalTo(1));
}

@SuppressWarnings({"rawtypes", "unchecked"})
@Test
public void shouldAddRecordsTwiceAndEvictRecordsOnce() {
when(serdeGetter.keySerde()).thenReturn((Serde) new Serdes.StringSerde());
Expand All @@ -158,6 +160,7 @@ public void shouldAddRecordsTwiceAndEvictRecordsOnce() {
assertThat(count.get(), equalTo(2));
}

@SuppressWarnings({"rawtypes", "unchecked"})
@Test
public void shouldDropLateRecords() {
when(serdeGetter.keySerde()).thenReturn((Serde) new Serdes.StringSerde());
Expand All @@ -180,6 +183,7 @@ public void shouldDropLateRecordsWithNonZeroGrace() {
assertNumSizeAndTimestamp(buffer, 2, 1, 84);
}

@SuppressWarnings({"rawtypes", "unchecked"})
@Test
public void shouldHandleCollidingKeys() {
when(serdeGetter.keySerde()).thenReturn((Serde) new Serdes.StringSerde());
Expand Down