KAFKA-18527: SaslClientsWithInvalidCredentialsTest.java should run for async consumer#18609
Closed
frankvicky wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-18527: SaslClientsWithInvalidCredentialsTest.java should run for async consumer#18609frankvicky wants to merge 1 commit intoapache:trunkfrom
frankvicky wants to merge 1 commit intoapache:trunkfrom
Conversation
github-actions
Bot
added
triage
…r async consumer JIRA: KAFKA-18527 Enable new consumer protocol for SaslClientsWithInvalidCredentialsTest.java. Since SaslClientsWithInvalidCredentialsTest.scala has some issues are still handled, I decide to open a PR for java first.
frankvicky
force-pushed
the
KAFKA-18527-1
branch
from
472f995 to
309fb32
Compare
kirktrue
approved these changes
Jan 21, 2025
Contributor
kirktrue
left a comment
kirktrue
left a comment
There was a problem hiding this comment.
LGTM. The tests are passing with the change, is there anything else that needs to be done before a committer can review? Thanks!
| @@ -149,7 +149,7 @@ public void testConsumerGroupServiceWithAuthenticationFailure(String quorum, Str | |||
| } | |||
|
|
|||
| @ParameterizedTest(name = "{displayName}.quorum={0}.groupProtocol={1}") | |||
Contributor
There was a problem hiding this comment.
Line 137 states that we can't use TestInfoUtils.TestWithParameterizedQuorumName() in the @ParameterizedTest annotation. Does it make sense to add that here, too?
Contributor
Author
There was a problem hiding this comment.
Interesting, I'm not very sure about this one 🤔
Member
There was a problem hiding this comment.
@frankvicky Could you please add the following comment to this test case?
// NOTE: Not able to refer TestInfoUtils#TestWithParameterizedQuorumName() in the ParameterizedTest name.
Contributor
|
@lianetm—would you review? Thanks! |
chia7712
reviewed
Jan 27, 2025
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@frankvicky thanks for the patch! I've got two small things to point out.
| @MethodSource("getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly") | ||
| @MethodSource("getTestQuorumAndGroupProtocolParametersAll") | ||
| public void testConsumerGroupServiceWithAuthenticationFailure(String quorum, String groupProtocol) throws Exception { | ||
| ConsumerGroupCommand.ConsumerGroupService consumerGroupService = prepareConsumerGroupService(); |
Member
There was a problem hiding this comment.
As we are modifying this PR, could you please close consumerGroupService via try-release also? For example:
try (ConsumerGroupCommand.ConsumerGroupService consumerGroupService = prepareConsumerGroupService();
Consumer<byte[], byte[]> consumer = createConsumer()) {
consumer.subscribe(Collections.singletonList(TOPIC));
verifyAuthenticationException(consumerGroupService::listGroups);
}| @MethodSource("getTestQuorumAndGroupProtocolParametersAll") | ||
| public void testConsumerGroupServiceWithAuthenticationSuccess(String quorum, String groupProtocol) throws Exception { | ||
| createScramCredentialsViaPrivilegedAdminClient(JaasTestUtils.KAFKA_SCRAM_USER_2, JaasTestUtils.KAFKA_SCRAM_PASSWORD_2); | ||
| ConsumerGroupCommand.ConsumerGroupService consumerGroupService = prepareConsumerGroupService(); |
Contributor
Author
|
This issue will fixed by #18668 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: KAFKA-18527
Enable new consumer protocol for
SaslClientsWithInvalidCredentialsTest.javaSince
SaslClientsWithInvalidCredentialsTest.scalahas some issues when enabling new consumer protocol, I decide to open a PR for java first.Committer Checklist (excluded from commit message)