KAFKA-18488: Improve KafkaShareConsumerTest#18728
Merged
AndrewJSchofield merged 4 commits intoapache:trunkfrom Jan 29, 2025
Merged
KAFKA-18488: Improve KafkaShareConsumerTest#18728AndrewJSchofield merged 4 commits intoapache:trunkfrom
AndrewJSchofield merged 4 commits intoapache:trunkfrom
Conversation
github-actions
Bot
added
consumer
tests
lianetm
reviewed
Jan 28, 2025
Member
lianetm
left a comment
lianetm
left a comment
There was a problem hiding this comment.
Thanks, the fix makes sense to me, just one comment
| return request.data().groupId().equals(groupId) && | ||
| request.data().shareSessionEpoch() == -1 && | ||
| request.data().topics().isEmpty(); | ||
| if (body instanceof ShareAcknowledgeRequest) { |
Member
There was a problem hiding this comment.
should we include the same check in the testVerifyHeartbeats?
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Jan 30, 2025
…ibrdkafka-compressed-produce-fails * apache-github/trunk: MINOR: prevent exception from HdrHistogram (apache#18674) KAFKA-18653: Fix mocks and potential thread leak issues causing silent RejectedExecutionException in share group broker tests (apache#18725) KAFKA-18646: Null records in fetch response breaks librdkafka (apache#18726) KAFKA-18619: New consumer topic metadata events should set requireMetadata flag (apache#18668) KAFKA-18488: Improve KafkaShareConsumerTest (apache#18728)
pdruley
pushed a commit
to pdruley/kafka
that referenced
this pull request
Feb 12, 2025
Reviewers: Lianet Magrans <lmagrans@confluent.io>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
Reviewers: Lianet Magrans <lmagrans@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KafkaShareConsumer.testVerifyFetchAndAcknowledgeSyncis occasionally failing. The underlying problem appears to be aClassCastExceptionin a request matcher.Committer Checklist (excluded from commit message)