Skip to content

MINOR: Fix wrong config property in KafkaConfigTest #18815

Merged
chia7712 merged 1 commit intoapache:trunkfrom
mingyen066:MINOR-Fix-wrong-config-property-in-KafkaConfigTest
Feb 6, 2025
Merged

MINOR: Fix wrong config property in KafkaConfigTest #18815
chia7712 merged 1 commit intoapache:trunkfrom
mingyen066:MINOR-Fix-wrong-config-property-in-KafkaConfigTest

Conversation

@mingyen066
Copy link
Copy Markdown
Collaborator

@mingyen066 mingyen066 commented Feb 6, 2025

Based on the discussion: https://github.com/apache/kafka/pull/18547/files#r1944140562

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions Bot added triage PRs from the community core Kafka Broker tests Test fixes (including flaky tests) small Small PRs labels Feb 6, 2025
Copy link
Copy Markdown
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Fix, LGTM

@chia7712 chia7712 merged commit 34e7136 into apache:trunk Feb 6, 2025
chia7712 pushed a commit that referenced this pull request Feb 6, 2025
Reviewers: Ken Huang <s7133700@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
@chia7712
Copy link
Copy Markdown
Member

chia7712 commented Feb 6, 2025

cherry-pick to 4.0

@github-actions github-actions Bot removed the triage PRs from the community label Feb 7, 2025
pdruley pushed a commit to pdruley/kafka that referenced this pull request Feb 12, 2025
Reviewers: Ken Huang <s7133700@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025
Reviewers: Ken Huang <s7133700@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
@mingyen066 mingyen066 deleted the MINOR-Fix-wrong-config-property-in-KafkaConfigTest branch March 23, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-approved core Kafka Broker small Small PRs tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants