Closed
Conversation
Make sure newer segments would not be deleted
Contributor
|
I think this shouldn't happen because we are using Log.deleteOldSegments which should delete from old to new until there is a segment which doesn't need deleting when it stops. In other words that pre-condition is enforced in the application of the method. Are you able to reproduce a problem? |
ymatsuda
referenced
this pull request
in confluentinc/kafka
Aug 5, 2015
do not clone kstream context
ymatsuda
added a commit
to ymatsuda/kafka
that referenced
this pull request
Aug 28, 2015
fix KStreamBranchTest
Parth-Brahmbhatt
added a commit
to Parth-Brahmbhatt/kafka
that referenced
this pull request
Mar 7, 2016
HDP-2.3.2.3: HOTFIX for EAR-2900
resetius
pushed a commit
to resetius/kafka
that referenced
this pull request
Jun 7, 2016
[LOGBROKER-231] Fix key id
jamesrgrinter
pushed a commit
to jamesrgrinter/kafka
that referenced
this pull request
Feb 2, 2018
bug 26111 Use negativeoffset instead of zerooffset flag from 6.0
ying-zheng
added a commit
to ying-zheng/kafka
that referenced
this pull request
Oct 31, 2019
RSM class loader
efeg
pushed a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
The following bugs are fixed: 1. The snapshot window time order was inconsistent in Load, which causes unit test failure. 2. The calculation of number of valid windows in `LoadMonitor.state()` was inconsistent to what we have in MetricSampleAggregator.
mjsax
pushed a commit
to mjsax/kafka
that referenced
this pull request
Jul 21, 2024
…_classes Add streams group member
mumrah
referenced
this pull request
in mumrah/kafka
Aug 14, 2024
### What * implemented logic to create share update snapshots. * fixed bug in share snapshot creation where entire state was not being saved. * use timeline hashmaps for leaderEpoch and snapshot update count. * refactored read and write state kafkaapis to be async * updated tests ### Why * Share snapshot update is an optimization where we only save the incremental state as a separate record in the internal topic, instead of the entire soft state ### Testing * updated existing tests.
fvaleri
pushed a commit
to fvaleri/kafka
that referenced
this pull request
Sep 20, 2025
Create cl coordinator skeleton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure newer segments would not be deleted