Skip to content

KAFKA-14487: Move LogManager static methods/fields to storage module #19302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mimaison merged 1 commit into from
Apr 21, 2025
Merged

KAFKA-14487: Move LogManager static methods/fields to storage module #19302

mimaison merged 1 commit into from
Apr 21, 2025

Conversation

@mimaison
Copy link
Member

@mimaison mimaison commented Mar 27, 2025 •
edited by github-actions bot
Loading

Move the static fields/methods

Reviewers: Luke Chen showuon@gmail.com

@github-actions github-actions bot added core Kafka Broker storage Pull requests that target the storage module build Gradle build or GitHub Actions labels Mar 27, 2025
@mimaison
Copy link
Member Author

mimaison commented Mar 27, 2025

We can't quite move the whole LogManager class yet as it still depends on KafkaConfig. Still it's useful to move its static methods/fields as these are used in RaftManager and BrokerMetadataPublisher.

FrankYang0529
FrankYang0529 approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the patch.

@showuon showuon self-assigned this Apr 15, 2025
showuon
showuon approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mimaison mimaison merged commit 7710d1c into apache:trunk Apr 21, 2025
23 checks passed
@mimaison mimaison deleted the kafka-14487 branch April 21, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FrankYang0529 FrankYang0529 FrankYang0529 approved these changes

@showuon showuon showuon approved these changes

Assignees

@showuon showuon

Labels

build Gradle build or GitHub Actions core Kafka Broker storage Pull requests that target the storage module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mimaison @FrankYang0529 @showuon