Skip to content

KAFKA-18752: Fix the warning of no-operation caused by slf4j in building kafka#19501

Closed
frankvicky wants to merge 57 commits intoapache:trunkfrom
frankvicky:KAFKA-18752
Closed

KAFKA-18752: Fix the warning of no-operation caused by slf4j in building kafka#19501
frankvicky wants to merge 57 commits intoapache:trunkfrom
frankvicky:KAFKA-18752

Conversation

@frankvicky
Copy link
Copy Markdown
Contributor

@frankvicky frankvicky commented Apr 17, 2025

JIRA: KAFKA-18752 In KAFKA-18466, we remove the slf4j impl from runtime
scope to fix the compatibility issue (see
#17373 (comment)).
However, that also causes a side effect: when running some tasks, slf4j
can't find any provider as they are included in "release-only". We could
fix this by adding releaseOnly to the class path.

This patch leverages the task collection API to enable specific tasks to
access releaseOnly dependencies.

…ing kafka

JIRA: KAFKA-18752
In KAFKA-18466 we remove the slf4j impl from runtime scope to fix the
compatible issue (see
apache#17373 (comment)).
However, that also causes a side effect that in running some tasks slf4k
can't find any provider as they are included to "release-only"
We could fix this by adding releasOnly to class path
@frankvicky frankvicky requested a review from chia7712 April 17, 2025 06:21
@github-actions github-actions bot added triage PRs from the community build Gradle build or GitHub Actions small Small PRs labels Apr 17, 2025
@frankvicky
Copy link
Copy Markdown
Contributor Author

Build output:
image

Copy link
Copy Markdown
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an typo in your description 'slf4k' should be 'slf4j'

@github-actions github-actions bot removed the triage PRs from the community label Apr 18, 2025
@github-actions
Copy link
Copy Markdown

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale Stale PRs label Jan 24, 2026
@github-actions
Copy link
Copy Markdown

This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.

@github-actions github-actions bot added the closed-stale PRs that were closed due to inactivity label Feb 23, 2026
@github-actions github-actions bot closed this Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Gradle build or GitHub Actions closed-stale PRs that were closed due to inactivity small Small PRs stale Stale PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants