Skip to content

Conversation

@dajac
Copy link
Member

@dajac dajac commented Apr 24, 2025

This patch does a few code changes:

  • It cleans up the GroupCoordinatorService;
  • It moves the helper methods to validate request to Utils;
  • It moves the helper methods to create the assignment for the
    ConsumerGroupHeartbeatResponse and the ShareGroupHeartbeatResponse from
    the GroupMetadataManager to the respective classes.

Reviewers: Chia-Ping Tsai chia7712@gmail.com, Jeff Kim
jeff.kim@confluent.io

@dajac dajac changed the title Minor small refactor in group coordinator MINOR: Small refactor in group coordinator Apr 24, 2025
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dajac dajac merged commit a948537 into apache:trunk Apr 24, 2025
24 checks passed
@dajac dajac deleted the minor-small-refactor-in-group-coordinator branch April 24, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants