MINOR: Optimize the entriesWithoutErrorsPerPartition when errorResults is empty#20410
Merged
chia7712 merged 2 commits intoapache:trunkfrom Aug 26, 2025
Merged
MINOR: Optimize the entriesWithoutErrorsPerPartition when errorResults is empty#20410chia7712 merged 2 commits intoapache:trunkfrom
chia7712 merged 2 commits intoapache:trunkfrom
Conversation
github-actions
Bot
added
triage
3 tasks
chia7712
reviewed
Aug 26, 2025
| val entriesWithoutErrorsPerPartition = entriesPerPartition.filter { case (key, _) => !errorResults.contains(key) } | ||
| val entriesWithoutErrorsPerPartition = | ||
| if (errorResults.nonEmpty) entriesPerPartition.filter { case (key, _) => !errorResults.contains(key) } | ||
| else entriesPerPartition |
Member
There was a problem hiding this comment.
Could you please add comments explaining the minor optimization?
chia7712
approved these changes
Aug 26, 2025
eduwercamacaro
pushed a commit
to littlehorse-enterprises/kafka
that referenced
this pull request
Nov 12, 2025
…s is empty (apache#20410) If `errorResults` is empty, there’s no need to create a new `entriesPerPartition` map. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
errorResultsis empty, there’s no need to create a newentriesPerPartitionmap.Reviewers: Chia-Ping Tsai chia7712@gmail.com