KAFKA-1901: follow-up on KAFKA-1901; Added error handling.#209
KAFKA-1901: follow-up on KAFKA-1901; Added error handling.#209omkreddy wants to merge 2 commits intoapache:trunkfrom omkreddy:KAFKA-1901
Conversation
|
@omkreddy If there is no file exist in .git/refs/heads, could we search in .git/packed-refs? |
|
@guozhangwang Yes, we can implement. But there may be other git scenarios, we may get similar exception. Current patch captures git commitID, if we are building on trunk/branch/tag (these common ways of building, for other scenarios it will just returns "unknown" commitID. I feel current functionality is sufficient for general build scenarios. Let me know your thoughts. |
There was a problem hiding this comment.
Are we supposed to assign a value to commitId in the else or am I missing something? Or maybe we don't need the else at all?
|
@ijuma thank for the review. I just removed unnecessary else block. |
|
kafka-trunk-git-pr #480 FAILURE |
|
@guozhangwang Do you want to check this PR again? |
|
LGTM. Merging to trunk. |
Adds AGPL license file. Adds Apache license file on different file name. Adds License file explaining the licensing of the project. Signed-off-by: Josep Prat <josep.prat@aiven.io>
Adds AGPL license file. Adds Apache license file on different file name. Adds License file explaining the licensing of the project. Signed-off-by: Josep Prat <josep.prat@aiven.io>
4 participants
@guozhangwang added .git/refs/heads/ file existence check.