MINOR: Correct exception naming and preserve original headers in DLQ#21370
Merged
lucasbru merged 3 commits intoapache:trunkfrom Jan 30, 2026
Merged
MINOR: Correct exception naming and preserve original headers in DLQ#21370lucasbru merged 3 commits intoapache:trunkfrom
lucasbru merged 3 commits intoapache:trunkfrom
Conversation
Per KIP-1034 spec, the __streams.errors.exception header should contain the "Name of the thrown exception" (class name), not the toString() output. Changed e.toString() to e.getClass().getName() in ExceptionHandlerUtils.
chia7712
changed the title
Member
@unknowntpo Would you mind opening a PR against the 4.2 branch? We had to disable FinalParameters in #20726 because the new Checkstyle has stricter enforcement. |
Contributor
Author
|
@chia7712 Sure, I'll do it ASAP. |
unknowntpo
added a commit
to unknowntpo/kafka
that referenced
this pull request
Jan 31, 2026
…pache#21370) This patch fixed two mismatch between [KIP-1034](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1034%3A+Dead+letter+queue+in+Kafka+Streams#KIP1034:DeadletterqueueinKafkaStreams-ProposedChanges) and the actual implementation: - Incorrect value of `HEADER_ERRORS_EXCEPTION_NAME`, it should be the name of the thrown exception, not exception's String representation. - Original headers from record that causes exception should be added to dlq record headers. References: - apache#17942 (comment) - apache#17942 (comment) - [KIP-1034](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1034%3A+Dead+letter+queue+in+Kafka+Streams#KIP1034:DeadletterqueueinKafkaStreams-ProposedChanges) Reviewers: Lucas Brutschy <lbrutschy@confluent.io>
unknowntpo
added a commit
to unknowntpo/kafka
that referenced
this pull request
Jan 31, 2026
…pache#21370) This patch fixed two mismatch between [KIP-1034](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1034%3A+Dead+letter+queue+in+Kafka+Streams#KIP1034:DeadletterqueueinKafkaStreams-ProposedChanges) and the actual implementation: - Incorrect value of `HEADER_ERRORS_EXCEPTION_NAME`, it should be the name of the thrown exception, not exception's String representation. - Original headers from record that causes exception should be added to dlq record headers. References: - apache#17942 (comment) - apache#17942 (comment) - [KIP-1034](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1034%3A+Dead+letter+queue+in+Kafka+Streams#KIP1034:DeadletterqueueinKafkaStreams-ProposedChanges) Reviewers: Lucas Brutschy <lbrutschy@confluent.io>
chia7712
pushed a commit
that referenced
this pull request
Jan 31, 2026
…21378) This is a backport of PR #21370, with an additional checkstyle fix (adding a `final` keyword to make checkstyle works in 4.2 branch). --- This patch fixed two mismatch between [KIP-1034](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1034%3A+Dead+letter+queue+in+Kafka+Streams#KIP1034:DeadletterqueueinKafkaStreams-ProposedChanges) and the actual implementation: - Incorrect value of `HEADER_ERRORS_EXCEPTION_NAME`, it should be the name of the thrown exception, not exception's String representation. - Original headers from record that causes exception should be added to dlq record headers. References: - #17942 (comment) - #17942 (comment) - [KIP-1034](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1034%3A+Dead+letter+queue+in+Kafka+Streams#KIP1034:DeadletterqueueinKafkaStreams-ProposedChanges) Reviewers: Lucas Brutschy <lbrutschy@confluent.io>, Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixed two mismatch between
KIP-1034
and the actual implementation:
HEADER_ERRORS_EXCEPTION_NAME, it should be thename of the thrown exception, not exception's String representation.
dlq record headers.
References:
KIP-1034
Reviewers: Lucas Brutschy lbrutschy@confluent.io