MINOR: AbstractSegments should not swallow exceptions#21636
Merged
mjsax merged 2 commits intoapache:trunkfrom Mar 6, 2026
Merged
MINOR: AbstractSegments should not swallow exceptions#21636mjsax merged 2 commits intoapache:trunkfrom
mjsax merged 2 commits intoapache:trunkfrom
Conversation
mjsax
commented
Mar 5, 2026
| public abstract class AbstractRocksDBWindowStoreTest extends AbstractWindowBytesStoreTest { | ||
|
|
||
| private static final String STORE_NAME = "rocksDB window store"; | ||
| private static final String STORE_NAME = "rocksDB-windowstore"; |
Member
Author
There was a problem hiding this comment.
not related -- but avoiding spaces sound like a good idea
mjsax
commented
Mar 5, 2026
|
|
||
| // remove local store image | ||
| Utils.delete(baseDir); | ||
| Utils.delete(new File(baseDir, STORE_NAME)); |
Member
Author
There was a problem hiding this comment.
We delete a directory "too high" in the hierarchy, and thus when we later try to create a segment we cannot, because the parent directory does not exist.
mjsax
commented
Mar 5, 2026
| final File oldSegment = new File(storeDirectoryPath + File.separator + storeName + "-" + formatter.format(new Date(segmentId * segmentInterval))); | ||
| //noinspection ResultOfMethodCallIgnored | ||
| Files.createFile(oldSegment.toPath()); | ||
| Files.createDirectory(oldSegment.toPath()); |
Member
Author
There was a problem hiding this comment.
Segments are directories -- if we create it here as a file, we later fail trying to create it as directory (create dir passed if dir already exists)
chia7712
approved these changes
Mar 5, 2026
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
LGTM, but I'm feeling a bit nitpicky today
| Arrays.stream(list) | ||
| .map(segment -> segmentIdFromSegmentName(segment, dir)) | ||
| .sorted() // open segments in the id order | ||
| .filter(segmentId -> segmentId >= 0) |
Member
There was a problem hiding this comment.
Nit: it would be better to apply filter before sort
| throw new ProcessorStateException(String.format("dir %s doesn't exist and cannot be created for segments %s", dir, name)); | ||
| } | ||
| final File dir = new File(context.stateDir(), name); | ||
| if (dir.exists()) { |
Member
There was a problem hiding this comment.
should we ensure the dir is a directory rather than regular file?
nicktelford
pushed a commit
to nicktelford/kafka
that referenced
this pull request
Mar 6, 2026
Reviewers: TengYao Chi <frankvicky@apache.org>, Chia-Ping Tsai <chia7712@gmail.com>
gabriellefu
pushed a commit
to gabriellefu/kafka
that referenced
this pull request
Mar 30, 2026
Reviewers: TengYao Chi <frankvicky@apache.org>, Chia-Ping Tsai <chia7712@gmail.com>
Shekharrajak
pushed a commit
to Shekharrajak/kafka
that referenced
this pull request
Mar 31, 2026
Reviewers: TengYao Chi <frankvicky@apache.org>, Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewers: TengYao Chi frankvicky@apache.org, Chia-Ping Tsai
chia7712@gmail.com