KAFKA-4480: Report an error in 'kafka-configs' command if the config to be removed does not exist#2218
KAFKA-4480: Report an error in 'kafka-configs' command if the config to be removed does not exist#2218vahidhashemian wants to merge 1 commit intoapache:trunkfrom
Conversation
…to be removed does not exist
vahidhashemian
force-pushed
the
KAFKA-4480
branch
from
61c7e07 to
3fe9b5a
Compare
|
LGTM, and merged to trunk. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Wouldn't it be better to fail the whole operation? That seems safer in my opinion. |
|
I think it is still safe to proceed the operation while filtering out the invalid config. I remember we did the same in some other console admin tools but I am not sure if it is still the case. |
|
@guozhangwang, there is no way to revert an incorrect delete. If someone mistyped one config, there could be other issues in the command. It's much safer to fail the whole operation and let the user retry the whole thing. I can't think of a scenario where it's actually helpful to do a partial delete. Can you? |
|
I think I agree. We could do a follow-up of this PR. |
|
Sounds good. @vahidhashemian, would you mind submitting a follow-up? Thanks! |
|
Definitely, I'll work on submitting a follow-up PR to fail the command in case of such user errors. |
…to be removed does not exist Author: Vahid Hashemian <vahidhashemian@us.ibm.com> Reviewers: Guozhang Wang <wangguoz@gmail.com> Closes apache#2218 from vahidhashemian/KAFKA-4480
4 participants
No description provided.