MINOR: Mx4jLoader always returns false even if mx4j is loaded & started#2295
Closed
eribeiro wants to merge 1 commit intoapache:trunkfrom
eribeiro:mx4jloader-bug
Closed
MINOR: Mx4jLoader always returns false even if mx4j is loaded & started#2295eribeiro wants to merge 1 commit intoapache:trunkfrom eribeiro:mx4jloader-bug
eribeiro wants to merge 1 commit intoapache:trunkfrom
eribeiro:mx4jloader-bug
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
Contributor
|
LGTM |
soenkeliebau
pushed a commit
to soenkeliebau/kafka
that referenced
this pull request
Feb 7, 2017
Mx4jLoader.scala should explicitly `return true` if the class is successfully loaded and started, otherwise it will return false even if the class is loaded. Author: Edward Ribeiro <edward.ribeiro@gmail.com> Reviewers: Ewen Cheslack-Postava <ewen@confluent.io> Closes apache#2295 from eribeiro/mx4jloader-bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mx4jLoader.scala should explicitly
return trueif the class is successfully loaded and started, otherwise it will return false even if the class is loaded.