KAFKA-3264: Deprecate the old Scala consumer (KIP-109) by vahidhashemian · Pull Request #2328 · apache/kafka

vahidhashemian · 2017-01-06T21:45:57Z

No description provided.

vahidhashemian · 2017-01-06T21:48:04Z

@ijuma With the assumption that KIP-109 will pass I started implementing the deprecation. While I continue to work on this I'd appreciate it if you could take a look and let me know if you see issues with respect to what class/method/... should or should not be deprecated. Thanks.

asfbot · 2017-01-06T22:27:14Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/584/
Test PASSed (JDK 8 and Scala 2.12).

asfbot · 2017-01-06T22:27:41Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/583/
Test PASSed (JDK 7 and Scala 2.10).

asfbot · 2017-01-06T22:29:27Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/585/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-01-09T19:13:57Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/633/
Test FAILed (JDK 8 and Scala 2.12).

asfbot · 2017-01-09T19:25:41Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/634/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-01-09T20:31:52Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/632/
Test PASSed (JDK 7 and Scala 2.10).

asfbot · 2017-02-11T00:40:33Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/1642/
Test FAILed (JDK 7 and Scala 2.10).

asfbot · 2017-02-11T01:23:07Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/1645/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-02-11T01:55:02Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1642/
Test FAILed (JDK 8 and Scala 2.12).

asfbot · 2017-03-14T22:19:51Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2180/
Test PASSed (JDK 8 and Scala 2.12).

asfbot · 2017-03-14T22:20:43Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2179/
Test PASSed (JDK 7 and Scala 2.10).

asfbot · 2017-03-14T22:25:09Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2185/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-03-14T22:25:26Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2182/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-03-14T22:26:43Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2182/
Test PASSed (JDK 7 and Scala 2.10).

asfbot · 2017-03-14T22:58:10Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2183/
Test FAILed (JDK 8 and Scala 2.12).

asfbot · 2017-04-11T21:49:22Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2898/
Test FAILed (JDK 8 and Scala 2.11).

asfbot · 2017-04-11T21:59:44Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2893/
Test PASSed (JDK 7 and Scala 2.10).

asfbot · 2017-04-11T22:14:30Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2894/
Test FAILed (JDK 8 and Scala 2.12).

ijuma · 2017-05-02T20:43:46Z

Sorry for the delay, I hope to take a look at this PR towards the end of this week.

Author: Vahid Hashemian <vahidhashemian@us.ibm.com> Reviewers: Ismael Juma <ismael@juma.me.uk> This patch had conflicts when merged, resolved by Committer: Ismael Juma <ismael@juma.me.uk> Closes #2328 from vahidhashemian/KAFKA-3264 (cherry picked from commit f85c180) Signed-off-by: Ismael Juma <ismael@juma.me.uk>

ijuma · 2017-06-02T11:34:38Z

@vahidhashemian, if you have time, it would be good to do a follow-up PR that fixes the deprecation warnings that can be fixed:

Uses of the old consumers in tools and tests where the new consumer would work as well (or better).
Methods in ClientUtils that are called by server or tools code should be introduced in AdminUtils with the implementation living in AdminUtils. All the existing callers apart from the old clients should call the AdminUtils methods.

Thanks.

vahidhashemian · 2017-06-02T15:08:31Z

@ijuma Definitely, I'll look into fixing those two. Thanks.

vahidhashemian changed the title ~~KAFKA-3264: Deprecate the old Scala consumer (WIP)~~ KAFKA-3264: Deprecate the old Scala consumer (KIP-109) (WIP) Jan 6, 2017

vahidhashemian force-pushed the KAFKA-3264 branch from 0fad531 to 1a68184 Compare January 9, 2017 18:33

vahidhashemian force-pushed the KAFKA-3264 branch 3 times, most recently from 3d6d460 to 5605a61 Compare February 11, 2017 00:36

vahidhashemian changed the title ~~KAFKA-3264: Deprecate the old Scala consumer (KIP-109) (WIP)~~ KAFKA-3264: Deprecate the old Scala consumer (KIP-109) Feb 11, 2017

vahidhashemian force-pushed the KAFKA-3264 branch 2 times, most recently from f292044 to 8ceec9a Compare March 14, 2017 21:40

KAFKA-3264: Deprecate the old Scala consumer (KIP-109)

3f01804

vahidhashemian force-pushed the KAFKA-3264 branch from 8ceec9a to 3f01804 Compare April 11, 2017 20:52

asfgit closed this in f85c180 Jun 2, 2017

vahidhashemian mentioned this pull request Jun 13, 2017

KAFKA-5370: Replace uses of the old consumer with the new consumer when possible #3320

Closed

Conversation

vahidhashemian commented Jan 6, 2017

Uh oh!

vahidhashemian commented Jan 6, 2017

Uh oh!

asfbot commented Jan 6, 2017

Uh oh!

asfbot commented Jan 6, 2017

Uh oh!

asfbot commented Jan 6, 2017

Uh oh!

asfbot commented Jan 9, 2017

Uh oh!

asfbot commented Jan 9, 2017

Uh oh!

asfbot commented Jan 9, 2017

Uh oh!

asfbot commented Feb 11, 2017

Uh oh!

asfbot commented Feb 11, 2017

Uh oh!

asfbot commented Feb 11, 2017

Uh oh!

asfbot commented Mar 14, 2017

Uh oh!

asfbot commented Mar 14, 2017

Uh oh!

asfbot commented Mar 14, 2017

Uh oh!

asfbot commented Mar 14, 2017

Uh oh!

asfbot commented Mar 14, 2017

Uh oh!

asfbot commented Mar 14, 2017

Uh oh!

asfbot commented Apr 11, 2017

Uh oh!

asfbot commented Apr 11, 2017

Uh oh!

asfbot commented Apr 11, 2017

Uh oh!

ijuma commented May 2, 2017

Uh oh!

ijuma commented Jun 2, 2017

Uh oh!

vahidhashemian commented Jun 2, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants