Skip to content

MINOR: rename SessionStore.findSessionsToMerge to findSessions#2339

Closed
dguy wants to merge 1 commit intoapache:trunkfrom
dguy:minor-findsession-rename
Closed

MINOR: rename SessionStore.findSessionsToMerge to findSessions#2339
dguy wants to merge 1 commit intoapache:trunkfrom
dguy:minor-findsession-rename

Conversation

@dguy
Copy link
Copy Markdown
Contributor

@dguy dguy commented Jan 10, 2017

Rename SessionStore.findSessionsToMerge to findSessions

@dguy
Copy link
Copy Markdown
Contributor Author

dguy commented Jan 10, 2017

@guozhangwang @enothereska @mjsax - a follow on from #2166
It was one of the review comments, but was merged before I'd gotten around to doing the rename

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 10, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/673/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 10, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/671/
Test PASSed (JDK 7 and Scala 2.10).

@guozhangwang
Copy link
Copy Markdown
Contributor

LGTM, merged to trunk, thanks!

@asfgit asfgit closed this in fe82330 Jan 10, 2017
@asfbot
Copy link
Copy Markdown

asfbot commented Jan 10, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/672/
Test PASSed (JDK 8 and Scala 2.12).

@dguy dguy deleted the minor-findsession-rename branch January 13, 2017 08:38
soenkeliebau pushed a commit to soenkeliebau/kafka that referenced this pull request Feb 7, 2017
Rename `SessionStore.findSessionsToMerge` to `findSessions`

Author: Damian Guy <damian.guy@gmail.com>

Reviewers: Guozhang Wang <wangguoz@gmail.com>

Closes apache#2339 from dguy/minor-findsession-rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants