MINOR: Finished exposing the broker config by enothereska · Pull Request #2350 · apache/kafka

enothereska · 2017-01-12T10:40:41Z

This was left over from KIP-104. Thanks to @ijuma for pointing out.

asfbot · 2017-01-12T11:27:04Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/784/
Test PASSed (JDK 8 and Scala 2.12).

asfbot · 2017-01-12T11:28:02Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/786/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-01-12T11:32:55Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/784/
Test PASSed (JDK 7 and Scala 2.10).

enothereska · 2017-01-12T14:46:53Z

@ijuma have a look when you can, thanks.

ijuma · 2017-01-13T02:03:51Z

Thanks @enothereska, can we add a simple unit test? LGTM otherwise.

enothereska · 2017-01-13T17:12:14Z

@ijuma I added a simple check, still thinking of what more to add at this level since there is testing at the sensor level.

…evel-config

asfbot · 2017-01-13T17:56:31Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/843/
Test PASSed (JDK 8 and Scala 2.12).

asfbot · 2017-01-13T17:57:42Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/845/
Test FAILed (JDK 8 and Scala 2.11).

asfbot · 2017-01-13T18:58:31Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/848/
Test PASSed (JDK 8 and Scala 2.12).

asfbot · 2017-01-13T19:10:16Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/850/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-01-13T19:32:09Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/848/
Test FAILed (JDK 7 and Scala 2.10).

enothereska · 2017-01-13T19:34:01Z

Known failure being worked on: org.apache.kafka.streams.integration.QueryableStateIntegrationTest.shouldNotMakeStoreAvailableUntilAllStoresAvailable[1]

asfbot · 2017-01-13T20:11:56Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/843/
Test FAILed (JDK 7 and Scala 2.10).

ijuma · 2017-01-16T11:48:07Z

@enothereska, the test I had in mind is to verify that MetricConfig had the right recording level if the broker config is set. That is what has changed in this PR. Before this PR, the information was not propagated to that class. I agree that the sensor tests are the right place to verify that the recording level is used in the right way.

enothereska · 2017-01-17T13:20:52Z

Thanks @ijuma I added a test as you suggested.

asfbot · 2017-01-17T14:09:06Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/930/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-01-17T14:13:21Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/928/
Test FAILed (JDK 7 and Scala 2.10).

enothereska · 2017-01-17T15:30:45Z

Known issue pure virtual method called not related to PR.
Known streams issues not related to PR:
org.apache.kafka.streams.integration.KStreamRepartitionJoinTest.shouldCorrectlyRepartitionOnJoinOperations[0]
org.apache.kafka.streams.integration.KStreamRepartitionJoinTest.shouldCorrectlyRepartitionOnJoinOperations[1]
org.apache.kafka.streams.integration.QueryableStateIntegrationTest.queryOnRebalance[0]

asfbot · 2017-01-17T15:33:06Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/928/
Test FAILed (JDK 8 and Scala 2.12).

…onfig

asfbot · 2017-01-18T09:00:24Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/980/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-01-18T09:07:47Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/978/
Test PASSed (JDK 7 and Scala 2.10).

asfbot · 2017-01-18T10:17:11Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/978/
Test FAILed (JDK 8 and Scala 2.12).

enothereska · 2017-01-19T14:52:16Z

Needs to go to 0.10.2 as well please.

…onfig

asfbot · 2017-01-23T14:06:51Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/1107/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-01-23T14:31:27Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1105/
Test FAILed (JDK 8 and Scala 2.12).

ijuma

Thanks for the PR, LGTM. Merging to trunk and 0.10.2 (as it's a follow-up to KIP-105).

This is a KIP-104/105 follow-up. Thanks to ijuma for pointing out. Author: Eno Thereska <eno.thereska@gmail.com> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes #2350 from enothereska/minor-broker-level-config (cherry picked from commit 1eb1e2f) Signed-off-by: Ismael Juma <ismael@juma.me.uk>

ijuma · 2017-01-23T15:20:05Z

For the record, I did some minor style and test clean-ups before merging.

enothereska · 2017-01-23T15:21:29Z

Thanks @ijuma

asfbot · 2017-01-23T15:31:28Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/1105/
Test PASSed (JDK 7 and Scala 2.10).

This is a KIP-104/105 follow-up. Thanks to ijuma for pointing out. Author: Eno Thereska <eno.thereska@gmail.com> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes apache#2350 from enothereska/minor-broker-level-config

Finished exposing the broker config

70e48d7

Added simple check

5593465

Merge remote-tracking branch 'apache-kafka/trunk' into minor-broker-l…

c2eaad7

…evel-config

Merge with trunk

3cfe778

Added unit test

294cc60

Merge remote-tracking branch 'origin/trunk' into minor-broker-level-c…

f46124e

…onfig

Merge remote-tracking branch 'origin/trunk' into minor-broker-level-c…

3eb2e4b

…onfig

Put metrics from config as part of object as Ismael suggested

6baa5e5

ijuma approved these changes Jan 23, 2017

View reviewed changes

asfgit closed this in 1eb1e2f Jan 23, 2017

enothereska deleted the minor-broker-level-config branch January 23, 2017 15:21

Conversation

enothereska commented Jan 12, 2017

Uh oh!

asfbot commented Jan 12, 2017

Uh oh!

asfbot commented Jan 12, 2017

Uh oh!

asfbot commented Jan 12, 2017

Uh oh!

enothereska commented Jan 12, 2017

Uh oh!

ijuma commented Jan 13, 2017

Uh oh!

enothereska commented Jan 13, 2017

Uh oh!

asfbot commented Jan 13, 2017

Uh oh!

asfbot commented Jan 13, 2017

Uh oh!

asfbot commented Jan 13, 2017

Uh oh!

asfbot commented Jan 13, 2017

Uh oh!

asfbot commented Jan 13, 2017

Uh oh!

enothereska commented Jan 13, 2017

Uh oh!

asfbot commented Jan 13, 2017

Uh oh!

ijuma commented Jan 16, 2017

Uh oh!

enothereska commented Jan 17, 2017

Uh oh!

asfbot commented Jan 17, 2017

Uh oh!

asfbot commented Jan 17, 2017

Uh oh!

enothereska commented Jan 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asfbot commented Jan 17, 2017

Uh oh!

asfbot commented Jan 18, 2017

Uh oh!

asfbot commented Jan 18, 2017

Uh oh!

asfbot commented Jan 18, 2017

Uh oh!

enothereska commented Jan 19, 2017

Uh oh!

asfbot commented Jan 23, 2017

Uh oh!

asfbot commented Jan 23, 2017

Uh oh!

ijuma left a comment

Choose a reason for hiding this comment

Uh oh!

ijuma commented Jan 23, 2017

Uh oh!

enothereska commented Jan 23, 2017

Uh oh!

asfbot commented Jan 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

enothereska commented Jan 17, 2017 •

edited

Loading