KAFKA-3452: follow up - fix state store restoration for session and window stores#2359
Closed
dguy wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-3452: follow up - fix state store restoration for session and window stores#2359dguy wants to merge 1 commit intoapache:trunkfrom
dguy wants to merge 1 commit intoapache:trunkfrom
Conversation
Contributor
Author
|
@guozhangwang, @mjsax, @enothereska - discovered this today during refactoring of stores. I think this is pretty important! |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
Contributor
Contributor
Author
|
@guozhangwang - looks like it wont be needed. Thanks for pointing out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The refactoring of the stores in #2166 introduced
ChangeLoggingSegmentedBytesStore, thus removing the change logging from theRocksDBWindowStoreetc. However, the inner most store still needs to know whether or not logging is enabled such that it can register correctly withProcessorContextand enable StateStore restoration