Skip to content

KAFKA-3452: follow up - fix state store restoration for session and window stores#2359

Closed
dguy wants to merge 1 commit intoapache:trunkfrom
dguy:hot-fix-store-logging
Closed

KAFKA-3452: follow up - fix state store restoration for session and window stores#2359
dguy wants to merge 1 commit intoapache:trunkfrom
dguy:hot-fix-store-logging

Conversation

@dguy
Copy link
Copy Markdown
Contributor

@dguy dguy commented Jan 12, 2017

The refactoring of the stores in #2166 introduced ChangeLoggingSegmentedBytesStore, thus removing the change logging from the RocksDBWindowStore etc. However, the inner most store still needs to know whether or not logging is enabled such that it can register correctly with ProcessorContext and enable StateStore restoration

@dguy
Copy link
Copy Markdown
Contributor Author

dguy commented Jan 12, 2017

@guozhangwang, @mjsax, @enothereska - discovered this today during refactoring of stores. I think this is pretty important!

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 12, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/805/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 12, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/803/
Test PASSed (JDK 8 and Scala 2.12).

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 12, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/803/
Test PASSed (JDK 7 and Scala 2.10).

@guozhangwang
Copy link
Copy Markdown
Contributor

@dguy Is this still needed after #2338 is merged? In that case ProcessorStateManager will already know which stores are change-logging enabled so that the second parameter of register(..) is not needed at all.

@dguy
Copy link
Copy Markdown
Contributor Author

dguy commented Jan 13, 2017

@guozhangwang - looks like it wont be needed. Thanks for pointing out.

@dguy dguy closed this Jan 16, 2017
@dguy dguy deleted the hot-fix-store-logging branch May 16, 2017 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants