Conversation
…reating and deleting topics. They work in IDE but fail while build. Removing the new tests for now.
…ing in StreamPartitionAssignor.
…new' of https://github.com/hjafarpour/kafka into KAFKA-4060-Remove-ZkClient-dependency-in-Kafka-Streams-new
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
| Please refer to the <code>KafkaConsumer</code> Javadoc for a more in-depth explanation of this change.</li> | ||
| <li>Multiple regular expressions separated by commas can be passed to MirrorMaker with the new Java consumer via the --whitelist option. This | ||
| makes the behaviour consistent with MirrorMaker when used the old Scala consumer.</li> | ||
| <li>Zookeeper dependency was removed from Streams API. Now Streams API uses Admin Client API to manage internal topics. If the Kafka cluster is secured the Streams apps require to have proper security privilege to create new topics.</li> |
There was a problem hiding this comment.
I am not sure it makes sense to say Admin Client API since it doesn't really exist. I think it would be better to say that the Kafka protocol is used to manage topics instead of modifying ZooKeeper. Also, more important than ZooKeeper dependency (which sounds like a library dependency) is the fact that network and write access to ZooKeeper is no longer required.
There was a problem hiding this comment.
Good point, will update the page accordingly.
|
Why does this change code? Shouldn't it only touch |
|
@hjafarpour Could you use |
|
I'm rebasing the branch and making minor changes based on @ijuma comment. |
| <li>Multiple regular expressions separated by commas can be passed to MirrorMaker with the new Java consumer via the --whitelist option. This | ||
| makes the behaviour consistent with MirrorMaker when used the old Scala consumer.</li> | ||
| <li>Zookeeper dependency was removed from the Streams API. Now the Streams API uses Kafka protocol to manage internal topics instead of modifying Zookeeprt directly. This eliminates the need for privilege[s] for accessing Zookeeper directly. If the Kafka cluster is secured the Streams apps require to have proper security privilege[s] to create new topics.</li> | ||
| <li>Several new fields including SECURITY_PROTOCOL_CONFIG, CONNECTIONS_MAX_IDLE_MS_CONFIG, RETRY_BACKOFF_MS_CONFIG RECONNECT_BACKOFF_MS_CONFIG and REQUEST_TIMEOUT_MS_CONFIG were added to StreamsConfig. User should pay attenntion to the default values and set these if needed.</li> |
There was a problem hiding this comment.
We need to provide the actually string name of the config instead of the variable names as they are internal variables and users would not recognize them. Also add a link to the configs section mentioning "please find the detailed description blah blah.."
There was a problem hiding this comment.
Got it, updating accordingly!
Updated the docs with changes in KAFKA-4060. Author: Hojjat Jafarpour <hojjat@Hojjat-Jafarpours-MBP.local> Author: Hojjat Jafarpour <hojjat@HojjatJpoursMBP.attlocal.net> Reviewers: Ismael Juma, Matthias J. Sax, Guozhang Wang Closes #2377 from hjafarpour/KAFKA-4060-docs-update (cherry picked from commit 62206de) Signed-off-by: Guozhang Wang <wangguoz@gmail.com>
|
Merged to trunk and 0.10.2. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
Updated the docs with changes in KAFKA-4060. Author: Hojjat Jafarpour <hojjat@Hojjat-Jafarpours-MBP.local> Author: Hojjat Jafarpour <hojjat@HojjatJpoursMBP.attlocal.net> Reviewers: Ismael Juma, Matthias J. Sax, Guozhang Wang Closes apache#2377 from hjafarpour/KAFKA-4060-docs-update
5 participants
Updated the docs with changes in KAFKA-4060.