MINOR: refactor streams system test class hierachy by mjsax · Pull Request #2392 · apache/kafka

mjsax · 2017-01-18T01:05:04Z

No description provided.

mjsax · 2017-01-18T01:06:08Z

Reworking in preparation to add new system tests.

Also for 0.10.2

asfbot · 2017-01-18T01:55:22Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/965/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-01-18T01:55:52Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/963/
Test PASSed (JDK 8 and Scala 2.12).

guozhangwang · 2017-01-18T02:21:53Z

LGTM overall, could you trigger one simplebenchmark test locally to make sure it works properly @mjsax ?

asfbot · 2017-01-18T03:23:15Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/963/
Test FAILed (JDK 7 and Scala 2.10).

mjsax · 2017-01-18T06:06:08Z

I did test with streams_shutdown_deadlock_test.py and it works there. (Also with the new test to be added for client-broker backwards compatibility).

For streams_simple_benchmark_test.py I found one problem that I fixed. But the benchmark never complete locally but crashes and times out. As it starts up, I guess it is working fine.

The error I get in stderr is (seems to be unrelated to the changes though -- WDYT?):

Exception in thread "StreamThread-3" org.apache.kafka.streams.errors.StreamsException: stream-thread [StreamThread-3] Failed to rebalance
        at org.apache.kafka.streams.processor.internals.StreamThread.runLoop(StreamThread.java:617)
        at org.apache.kafka.streams.processor.internals.StreamThread.run(StreamThread.java:369)
Caused by: java.lang.NullPointerException
        at org.apache.kafka.streams.processor.internals.ProcessorStateManager.register(ProcessorStateManager.java:133)
        at org.apache.kafka.streams.processor.internals.AbstractProcessorContext.register(AbstractProcessorContext.java:99)
        at org.apache.kafka.streams.state.internals.RocksDBStore.init(RocksDBStore.java:160)
        at org.apache.kafka.streams.state.internals.ChangeLoggingKeyValueBytesStore.init(ChangeLoggingKeyValueBytesStore.java:39)
        at org.apache.kafka.streams.state.internals.ChangeLoggingKeyValueStore.init(ChangeLoggingKeyValueStore.java:60)
        at org.apache.kafka.streams.state.internals.MeteredKeyValueStore$7.run(MeteredKeyValueStore.java:100)
        at org.apache.kafka.streams.processor.internals.StreamsMetricsImpl.measureLatencyNs(StreamsMetricsImpl.java:188)
        at org.apache.kafka.streams.state.internals.MeteredKeyValueStore.init(MeteredKeyValueStore.java:131)
        at org.apache.kafka.streams.processor.internals.AbstractTask.initializeStateStores(AbstractTask.java:86)
        at org.apache.kafka.streams.processor.internals.StreamTask.<init>(StreamTask.java:141)
        at org.apache.kafka.streams.processor.internals.StreamThread.createStreamTask(StreamThread.java:839)
        at org.apache.kafka.streams.processor.internals.StreamThread$TaskCreator.createTask(StreamThread.java:1212)
        at org.apache.kafka.streams.processor.internals.StreamThread$AbstractTaskCreator.retryWithBackoff(StreamThread.java:1185)
        at org.apache.kafka.streams.processor.internals.StreamThread.addStreamTasks(StreamThread.java:942)
        at org.apache.kafka.streams.processor.internals.StreamThread.access$500(StreamThread.java:69)
        at org.apache.kafka.streams.processor.internals.StreamThread$1.onPartitionsAssigned(StreamThread.java:236)
        at org.apache.kafka.clients.consumer.internals.ConsumerCoordinator.onJoinComplete(ConsumerCoordinator.java:230)
        at org.apache.kafka.clients.consumer.internals.AbstractCoordinator.joinGroupIfNeeded(AbstractCoordinator.java:336)
        at org.apache.kafka.clients.consumer.internals.AbstractCoordinator.ensureActiveGroup(AbstractCoordinator.java:300)
        at org.apache.kafka.clients.consumer.internals.ConsumerCoordinator.poll(ConsumerCoordinator.java:261)
        at org.apache.kafka.clients.consumer.KafkaConsumer.pollOnce(KafkaConsumer.java:1025)
        at org.apache.kafka.clients.consumer.KafkaConsumer.poll(KafkaConsumer.java:990)
        at org.apache.kafka.streams.processor.internals.StreamThread.runLoop(StreamThread.java:587)
        ... 1 more
```

asfbot · 2017-01-18T07:10:26Z

Build finished. 2890 tests run, 0 skipped, 1 failed.
Test FAILed (JDK 8 and Scala 2.12).

asfbot · 2017-01-18T07:10:27Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/976/
Test FAILed (JDK 8 and Scala 2.12).

asfbot · 2017-01-18T07:16:14Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/978/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-01-18T08:18:08Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/976/
Test FAILed (JDK 7 and Scala 2.10).

enothereska · 2017-01-18T11:59:57Z

Given that this changes the python code, it'd be good to trigger all system tests, including the smoke one and bounce one before merging.

enothereska · 2017-01-18T12:00:44Z

Also the benchmark test has always ran nightly, that needs to be part of tests to be run (as @mjsax has already done, thanks)

enothereska · 2017-01-18T12:01:34Z

@guozhangwang in an ideal world, this PR and PR: https://github.com/apache/kafka/pull/2391/files should go together.

guozhangwang · 2017-01-18T19:54:45Z

@enothereska System tests will take about 5 hours, and given that we are going to have nightly builds in another 10 hour, I'd say just watch the upcoming system test after merging this.

Author: Matthias J. Sax <matthias@confluent.io> Reviewers: Eno Thereska, Guozhang Wang Closes #2392 from mjsax/minor-system-test-rework (cherry picked from commit d8a7756) Signed-off-by: Guozhang Wang <wangguoz@gmail.com>

guozhangwang · 2017-01-18T19:56:04Z

LGTM. Merged to trunk and 0.10.2.

enothereska · 2017-01-19T07:52:11Z

@guozhangwang I think this is really bad. System tests for streams take just 5 mins/test, you don't have to run all the system tests, just streams.

ijuma · 2017-01-19T08:11:17Z

I agree with @enothereska, a change like this should not be merged before running the Streams system tests via the branch builder. It doesn't take long since there are a small number of Streams tests.

For Core, whenever we change shared security code, we run all the tests before merging even though they take several hours as there is a lot of value in catching issues before the code is merged.

enothereska · 2017-01-19T18:23:39Z

-        if len(self.pids(node)) == 0:
-            raise RuntimeError("No process ids recorded")
-
-    def collect_data(self, node):


Why is this removed?

This did not happen intentionally... Will open a PR to fix it.

guozhangwang · 2017-01-19T18:33:38Z

@enothereska @ijuma My apologies, I mis-understood Eno's comment before and was careless for merging the PR.

enothereska · 2017-01-19T19:50:35Z

        with node.account.monitor_log(self.STDOUT_FILE) as monitor:
            node.account.ssh(self.start_cmd(node))
-            monitor.wait_until('StreamsSmokeTest instance started', timeout_sec=15, err_msg="Never saw message indicating StreamsSmokeTest finished startup on " + str(node.account))
+            monitor.wait_until('StreamsTest instance started', timeout_sec=60, err_msg="Never saw message indicating StreamsTest finished startup on " + str(node.account))


This probably doesn't need to be increased since they start fast.

Author: Matthias J. Sax <matthias@confluent.io> Reviewers: Eno Thereska, Guozhang Wang Closes apache#2392 from mjsax/minor-system-test-rework

mjsax added 2 commits January 17, 2017 22:23

MINOR: refactor streams system test class hierachy

aeed622

fixed SimpleBenchmark startup issue

d36791c

mjsax force-pushed the minor-system-test-rework branch from 1e70ba7 to d36791c Compare January 18, 2017 06:26

asfgit closed this in d8a7756 Jan 18, 2017

mjsax deleted the minor-system-test-rework branch January 18, 2017 22:05

enothereska reviewed Jan 19, 2017

View reviewed changes

Conversation

mjsax commented Jan 18, 2017

Uh oh!

mjsax commented Jan 18, 2017

Uh oh!

asfbot commented Jan 18, 2017

Uh oh!

asfbot commented Jan 18, 2017

Uh oh!

guozhangwang commented Jan 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asfbot commented Jan 18, 2017

Uh oh!

mjsax commented Jan 18, 2017

Uh oh!

asfbot commented Jan 18, 2017

Uh oh!

asfbot commented Jan 18, 2017

Uh oh!

asfbot commented Jan 18, 2017

Uh oh!

asfbot commented Jan 18, 2017

Uh oh!

enothereska commented Jan 18, 2017

Uh oh!

enothereska commented Jan 18, 2017

Uh oh!

enothereska commented Jan 18, 2017

Uh oh!

guozhangwang commented Jan 18, 2017

Uh oh!

guozhangwang commented Jan 18, 2017

Uh oh!

enothereska commented Jan 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ijuma commented Jan 19, 2017

Uh oh!

enothereska Jan 19, 2017

Choose a reason for hiding this comment

Uh oh!

mjsax Jan 19, 2017

Choose a reason for hiding this comment

Uh oh!

guozhangwang commented Jan 19, 2017

Uh oh!

enothereska Jan 19, 2017

Choose a reason for hiding this comment

Uh oh!

mjsax Jan 19, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

guozhangwang commented Jan 18, 2017 •

edited

Loading

enothereska commented Jan 19, 2017 •

edited

Loading