Skip to content

MINOR: Fix javadoc typos in KStream#process#2396

Closed
dguy wants to merge 1 commit intoapache:trunkfrom
dguy:minor-javadoc
Closed

MINOR: Fix javadoc typos in KStream#process#2396
dguy wants to merge 1 commit intoapache:trunkfrom
dguy:minor-javadoc

Conversation

@dguy
Copy link
Copy Markdown
Contributor

@dguy dguy commented Jan 18, 2017

interface for Processor in comments incorrectly had transform rather than process.

@dguy
Copy link
Copy Markdown
Contributor Author

dguy commented Jan 18, 2017

@enothereska @ijuma

* }
*
* void transform(K key, V value) {
* void process(K key, V value) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@miguno
Copy link
Copy Markdown
Contributor

miguno commented Jan 18, 2017

LGTM

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 18, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/984/
Test PASSed (JDK 8 and Scala 2.12).

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 18, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/986/
Test PASSed (JDK 8 and Scala 2.11).

@dguy
Copy link
Copy Markdown
Contributor Author

dguy commented Jan 18, 2017

@guozhangwang

Copy link
Copy Markdown
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

asfgit pushed a commit that referenced this pull request Jan 18, 2017
interface for `Processor` in comments incorrectly had `transform` rather than `process`.

Author: Damian Guy <damian.guy@gmail.com>

Reviewers: Michael G. Noll, Ismael Juma <ismael@juma.me.uk>

Closes #2396 from dguy/minor-javadoc

(cherry picked from commit ccb183f)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
@ijuma
Copy link
Copy Markdown
Member

ijuma commented Jan 18, 2017

Merged to trunk and 0.10.2 branches.

@asfgit asfgit closed this in ccb183f Jan 18, 2017
@asfbot
Copy link
Copy Markdown

asfbot commented Jan 18, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/984/
Test FAILed (JDK 7 and Scala 2.10).

@dguy dguy deleted the minor-javadoc branch January 19, 2017 11:40
soenkeliebau pushed a commit to soenkeliebau/kafka that referenced this pull request Feb 7, 2017
interface for `Processor` in comments incorrectly had `transform` rather than `process`.

Author: Damian Guy <damian.guy@gmail.com>

Reviewers: Michael G. Noll, Ismael Juma <ismael@juma.me.uk>

Closes apache#2396 from dguy/minor-javadoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants