Skip to content

HOTFIX: KAFKA-4060 and KAFKA-4476 follow up#2418

Closed
mjsax wants to merge 2 commits intoapache:trunkfrom
mjsax:kafka-4060-zk-test-follow-up
Closed

HOTFIX: KAFKA-4060 and KAFKA-4476 follow up#2418
mjsax wants to merge 2 commits intoapache:trunkfrom
mjsax:kafka-4060-zk-test-follow-up

Conversation

@mjsax
Copy link
Copy Markdown
Member

@mjsax mjsax commented Jan 22, 2017

No description provided.

@mjsax mjsax mentioned this pull request Jan 22, 2017
Closed
@guozhangwang
Copy link
Copy Markdown
Contributor

guozhangwang commented Jan 22, 2017

Could you add a unit test for this?

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 22, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/1093/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 22, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1091/
Test PASSed (JDK 8 and Scala 2.12).

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 22, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/1091/
Test PASSed (JDK 7 and Scala 2.10).

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Jan 23, 2017

@guozhangwang Done.
I also split the existing test into two (to support @dguy's efforts to make our tests better)

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 23, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/1100/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 23, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1098/
Test PASSed (JDK 8 and Scala 2.12).

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 23, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/1098/
Test PASSed (JDK 7 and Scala 2.10).

dguy
dguy approved these changes Jan 23, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

asfgit pushed a commit that referenced this pull request Jan 23, 2017
@mjsax @guozhangwang
HOTFIX: KAFKA-4060 and KAFKA-4476 follow up
afde878 
Author: Matthias J. Sax <matthias@confluent.io>

Reviewers: Damian Guy, Guozhang Wang

Closes #2418 from mjsax/kafka-4060-zk-test-follow-up

(cherry picked from commit dd897bd)
Signed-off-by: Guozhang Wang <wangguoz@gmail.com>
@asfgit asfgit closed this in dd897bd Jan 23, 2017
@guozhangwang
Copy link
Copy Markdown
Contributor

guozhangwang commented Jan 23, 2017

LGTM and merged to trunk and 0.10.2.

@mjsax mjsax deleted the kafka-4060-zk-test-follow-up branch January 23, 2017 17:37
soenkeliebau pushed a commit to soenkeliebau/kafka that referenced this pull request Feb 7, 2017
@mjsax @soenkeliebau
HOTFIX: KAFKA-4060 and KAFKA-4476 follow up
dc90aac 
Author: Matthias J. Sax <matthias@confluent.io>

Reviewers: Damian Guy, Guozhang Wang

Closes apache#2418 from mjsax/kafka-4060-zk-test-follow-up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dguy dguy dguy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mjsax @guozhangwang @asfbot @dguy