MINOR: Replacing for with foreach loop in common module#2530
MINOR: Replacing for with foreach loop in common module#2530kashyap-prabhat wants to merge 1 commit intoapache:trunkfrom
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
ijuma
left a comment
ijuma
left a comment
There was a problem hiding this comment.
Thanks for the PR. The usage of the foreach loop looks good. However, there are a number of changes where the newline is removed after the foreach or if/else and we don't do that in Kafka's Java code (although we do in Scala's code).
There was a problem hiding this comment.
The convention (even though not enforced by checkstyle) is for parent.checkForest(sensors); to go in the next line for the Java code.
|
Refer to this link for build results (access rights to CI server needed): |
kashyap-prabhat
force-pushed
the
refactored-code
branch
from
5e2546c to
43edebe
Compare
|
@ijuma Thanks for pointing it out. Please check I have fixed it. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
ijuma
left a comment
ijuma
left a comment
There was a problem hiding this comment.
Thanks for the PR, LGTM. I fixed formatting in a few places before merging to trunk.
Author: Prabhat Kashyap <prabhat.kashyap@knoldus.in> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes apache#2530 from PKOfficial/refactored-code
3 participants
No description provided.