KAFKA-4774. Inner classes which don't need a reference to the outer c…#2558
KAFKA-4774. Inner classes which don't need a reference to the outer c…#2558cmccabe wants to merge 2 commits intoapache:trunkfrom
Conversation
…lass should be static
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
| } | ||
|
|
||
| class Pair { | ||
| static class Pair { |
There was a problem hiding this comment.
Seems this can be private?
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
| * A simple wrapper class to implement a doubly-linked list around MemoryLRUCacheBytesEntry | ||
| */ | ||
| class LRUNode { | ||
| static class LRUNode { |
There was a problem hiding this comment.
Seems like this one can be private too?
There was a problem hiding this comment.
I think it's used in NamedCacheTest
…lass should be static Author: Colin P. Mccabe <cmccabe@confluent.io> Reviewers: Jason Gustafson <jason@confluent.io>, Ismael Juma <ismael@juma.me.uk> Closes apache#2558 from cmccabe/KAFKA-4774
4 participants
…lass should be static