Skip to content

KAFKA-4777 fix client heartbeat non-stop retry issue. #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
allenxiang wants to merge 6 commits into from
Closed

KAFKA-4777 fix client heartbeat non-stop retry issue. #2564

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7500062
KAFKA-4777 fix client heartbeat non-stop retry issue.
Feb 17, 2017
5b7de76
check style fix.
Feb 17, 2017
7d598de
KAFKA-4777 fix client heartbeat non-stop retry issue. Code clean up.
Feb 18, 2017
1b0ee61
KAFKA-4777 fix client heartbeat non-stop retry issue. Address code re…
Feb 18, 2017
48f77e4
KAFKA-4777 fix client heartbeat non-stop retry issue. Fix brackets.
Feb 18, 2017
2999c16
KAFKA-4777 fix client heartbeat non-stop retry issue. Address code re…
Feb 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,9 +888,9 @@ public void run() {
long now = time.milliseconds();

if (coordinatorUnknown()) {
if (findCoordinatorFuture == null)
lookupCoordinator();
else
if (findCoordinatorFuture != null || lookupCoordinator().failed())
// the immediate future check ensures that we backoff properly in the case that no
// brokers are available to connect to.
AbstractCoordinator.this.wait(retryBackoffMs);
} else if (heartbeat.sessionTimeoutExpired(now)) {
// the session timeout has expired without seeing a successful heartbeat, so we should
Expand Down Expand Up @@ -941,7 +941,7 @@ public void onFailure(RuntimeException e) {
log.error("Unexpected interrupt received in heartbeat thread for group {}", groupId, e);
this.failed.set(new RuntimeException(e));
} catch (RuntimeException e) {
log.error("Heartbeat thread for group {} failed due to unexpected error" , groupId, e);
log.error("Heartbeat thread for group {} failed due to unexpected error", groupId, e);
this.failed.set(e);
} finally {
log.debug("Heartbeat thread for group {} has closed", groupId);
Expand Down