MINOR: Fixed 3 inner classes without instance reference to be static#2574
Closed
original-brownbear wants to merge 1 commit intoapache:trunkfrom
Closed
MINOR: Fixed 3 inner classes without instance reference to be static#2574original-brownbear wants to merge 1 commit intoapache:trunkfrom
original-brownbear wants to merge 1 commit intoapache:trunkfrom
Conversation
Member
Author
|
@hachikuji @ijuma ping :) |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
hachikuji
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Feb 23, 2017
* Turned 3 inner classes that weren't static but could be into `static` ones. * Turned one `public` inner class that wasn't used publicly into a `private`. Trivial but imo worthwhile to explicitly keep visibility and "staticness" correct in syntax (if only to be nice to the GC) :) Author: Armin Braun <me@obrown.io> Reviewers: Matthias J. Sax <matthias@confluent.io>, Jason Gustafson <jason@confluent.io> Closes apache#2574 from original-brownbear/cleanup-inner-nonstatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
staticones.publicinner class that wasn't used publicly into aprivate.Trivial but imo worthwhile to explicitly keep visibility and "staticness" correct in syntax (if only to be nice to the GC) :)