KAFKA-4657: Improve test coverage of CompositeReadOnlyWindowStore#2672
KAFKA-4657: Improve test coverage of CompositeReadOnlyWindowStore#2672adyach wants to merge 3 commits intoapache:trunkfrom adyach:trunk
Conversation
This commmit brings improved test coverage for window store fetch method and WindowStoreIterator
|
@guozhangwang @dguy please review when you have time |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
| } | ||
|
|
||
| @Test | ||
| public void testWindowStoreIterator() throws Exception { |
There was a problem hiding this comment.
Can you split this out into 2 tests please?. One for each method that is being tested. Thanks
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
| } | ||
|
|
||
| @Test | ||
| public void testWindowStoreIteratorHasNext() throws Exception { |
There was a problem hiding this comment.
it is preferable to have descriptive test names, i.e.,
emptyIteratorAlwaysReturnsFalse
emptyIteratorPeekNextKeyShouldThrowNoSuchElementException
etc
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
LGTM and merged to trunk. |
4 participants
This commmit brings improved test coverage for window store fetch method
and WindowStoreIterator