KAFKA-4863: [Follow Up] Querying window store may return unwanted keys#2713
KAFKA-4863: [Follow Up] Querying window store may return unwanted keys#2713dguy wants to merge 3 commits intoapache:trunkfrom
Conversation
|
@guozhangwang @xvrl - follow up to #2662 |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
| final long start = SessionKeySerde.extractStart(bytes.get()); | ||
| final long end = SessionKeySerde.extractEnd(bytes.get()); | ||
| return end >= from && start <= to; | ||
| if (keyBytes.equals(binaryKey) |
There was a problem hiding this comment.
minor performance nit, it might be worthwhile to have something like SessionKeySerde.inWindow(bytes, binaryKey, from, to) to avoid creating three bytebuffer objects for each comparison.
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
LGTM: merged to trunk. |
4 participants
iterate over all keys returned from the rocksdb iterator so we don't miss any results