KAFKA-4929: Transformation Key/Value type references should be to class name(), not canonicalName()#2720
KAFKA-4929: Transformation Key/Value type references should be to class name(), not canonicalName()#2720bruce-szalwinski wants to merge 2 commits intoapache:trunkfrom
Conversation
…renced using OuterClass$Key and OuterClass$Value.
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
cc @gwenshap |
|
Huge props for making the error message and doc output include the right description. Current situation is very misleading. Few comments:
Other than that, the change looks small and safe so +1, pending the possible short KIP for the new CLI and adding the docs. I'll also be happy to get this in if you remove the CLI and submit it in separate PR since it may require additional process. We can fix the errors faster this way. |
|
Thanks. The SMTs are pretty cool. I've removed the connect-plugin-discovery.sh from this PR. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Tested by generating the docs. LGTM. Thank you for fixing this. |
…ss name(), not canonicalName() Changing getCanonicalName() references to getName() so that docs update with "$" instead of ".". Also added a connect-plugin-discovery.sh CLI to list all of the transformations available. Author: Bruce Szalwinski <bruce.szalwinski@cdk.com> Reviewers: Gwen Shapira Closes apache#2720 from bruce-szalwinski/transforms and squashes the following commits: ec3b5b9 [Bruce Szalwinski] remove connect-plugin-discovery. will submit in a different PR eba0af7 [Bruce Szalwinski] Key / Value transformations are static nested classes and so are referenced using OuterClass$Key and OuterClass$Value. (cherry picked from commit 763ea5a)
4 participants
Changing getCanonicalName() references to getName() so that docs update with "$" instead of ".". Also added a connect-plugin-discovery.sh CLI to list all of the transformations available.